Bug 492326

Summary: Display bug in Filelight's diagrams resolving by hovering the mouse on it
Product: [Applications] filelight Reporter: Alexandre <a.guillet>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: martin.sandsmark, nate, sitter
Priority: NOR    
Version: 24.08.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 24.12.0
Sentry Crash Report:
Attachments: Bug at opening, then hovering the mouse around a bit, then a lot until the correct diagram displays.

Description Alexandre 2024-08-28 15:58:21 UTC
Created attachment 173050 [details]
Bug at opening, then hovering the mouse around a bit, then a lot until the correct diagram displays.

STEPS TO REPRODUCE
1. Open Dolphin
2. Right-click on any folder --> Property
3. Click Explore in Filelight

OR

1. Open Dolphin
2. Enter a folder
3. Click in the right bottom corner menu on the statistics for this folder

OBSERVED RESULT

Some segments appear off-centred, and disappear/appear on the right place when hovering these locations with the mouse. This happens in a Wayland session but not in a X11 session, and only when Filelight is opened from Dolphin.

EXPECTED RESULT

The mouse hovering seems to refresh the display of the diagram components. They should already be refreshed (in the right position) form the start.

SOFTWARE/OS VERSIONS
Linux: EndeavourOS x86_64
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2

ADDITIONAL INFORMATION
No bug in X11 session.
No bug when opening the user folder.
No bug when opening any folder launching Filelight independently from Dolphin.
Comment 1 Harald Sitter 2024-08-29 11:36:33 UTC
Cannot reproduce :(
Comment 2 Bug Janitor Service 2024-09-04 14:57:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/filelight/-/merge_requests/158
Comment 3 Harald Sitter 2024-09-18 14:00:08 UTC
Git commit b045a7bb5542df5b0de8f694d2733c9dfc91e3d9 by Harald Sitter.
Committed on 18/09/2024 at 12:05.
Pushed by sitter into branch 'master'.

shapes: force an update after processing

there is apparently a race condition somewhere inside the curve renderer
that leads to it not updating when points change. force an update of the
path by changing the fillcolor just after entering ready status.

has the unfortunate side effect that the map jumps ever so slightly
after inital rendering. still better than incorrect drawing though. we
do need curve renderer for it's superior curve rendering capabilities,
otherwise we'd get poor antialiasing.

https://bugreports.qt.io/browse/QTBUG-128637

M  +16   -1    src/qml/CenterShape.qml
M  +17   -1    src/qml/SegmentShape.qml

https://invent.kde.org/utilities/filelight/-/commit/b045a7bb5542df5b0de8f694d2733c9dfc91e3d9
Comment 4 Harald Sitter 2024-09-18 17:00:10 UTC
Git commit 5b16809b27e9cc5dd33be68a6629c1582ebc534b by Harald Sitter.
Committed on 18/09/2024 at 15:23.
Pushed by sitter into branch 'release/24.08'.

shapes: force an update after processing

there is apparently a race condition somewhere inside the curve renderer
that leads to it not updating when points change. force an update of the
path by changing the fillcolor just after entering ready status.

has the unfortunate side effect that the map jumps ever so slightly
after inital rendering. still better than incorrect drawing though. we
do need curve renderer for it's superior curve rendering capabilities,
otherwise we'd get poor antialiasing.

https://bugreports.qt.io/browse/QTBUG-128637
(cherry picked from commit b045a7bb5542df5b0de8f694d2733c9dfc91e3d9)

M  +16   -1    src/qml/CenterShape.qml
M  +17   -1    src/qml/SegmentShape.qml

https://invent.kde.org/utilities/filelight/-/commit/5b16809b27e9cc5dd33be68a6629c1582ebc534b