Bug 492246

Summary:	CI pipeline of work/port_qt6_try_2 fails on svg2png umbrello/pics/sources/accept_signal.svg
Product:	[Applications] umbrello	Reporter:	Oliver Kellogg <okellogg>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ralf.habacker
Priority:	NOR
Version:	Git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/sdk/umbrello/-/commit/461968b265df7a861b3b0282f42180c20aef1a82	Version Fixed In:
Sentry Crash Report:

Description Oliver Kellogg 2024-08-27 05:28:46 UTC

SUMMARY
CI pipeline of work/port_qt6_try_2 fails on svg2png umbrello/pics/sources/accept_signal.svg

STEPS TO REPRODUCE
1. Check out the work/port_qt6_try_2 branch at commit b0b9d18f48282104c2130626542808ae3e0fe720
2. mkdir build; cd build
3. Run `cmake` in your usual way (for example `cmake  -DCMAKE_BUILD_TYPE=Debug -DBUILD_QCH=0  ../`)
4. Run `make`
5. Run `./bin/svg2png ../umbrello/pics/sources/accept_signal.svg ../umbrello/pics/cursor-accept_signal.png 32 32 ../umbrello/pics/sources/cursor-template.svg`

OBSERVED RESULT

`svg2png` prints `qt.svg: link #(null) is undefined!`

See also https://invent.kde.org/sdk/umbrello/-/jobs/2079765 job log starting line 810:

make[2]: Entering directory '/builds/sdk/umbrello/_build'
[  7%] creating '/builds/sdk/umbrello/umbrello/pics/accept_signal.png' from '/builds/sdk/umbrello/umbrello/pics/sources/accept_signal.svg'
[  7%] creating '/builds/sdk/umbrello/umbrello/pics/cursor-accept_signal.png' from '/builds/sdk/umbrello/umbrello/pics/sources/accept_signal.svg'
cd /builds/sdk/umbrello/_build/umbrello/pics && ../../bin/svg2png /builds/sdk/umbrello/umbrello/pics/sources/accept_signal.svg /builds/sdk/umbrello/umbrello/pics/accept_signal.png 22 22
cd /builds/sdk/umbrello/_build/umbrello/pics && ../../bin/svg2png /builds/sdk/umbrello/umbrello/pics/sources/accept_signal.svg /builds/sdk/umbrello/umbrello/pics/cursor-accept_signal.png 32 32 /builds/sdk/umbrello/umbrello/pics/sources/cursor-template.svg
make[2]: *** [umbrello/pics/CMakeFiles/build_icons.dir/build.make:273: /builds/sdk/umbrello/umbrello/pics/accept_signal.png] Aborted
make[2]: *** [umbrello/pics/CMakeFiles/build_cursors.dir/build.make:148: /builds/sdk/umbrello/umbrello/pics/cursor-accept_signal.png] Aborted

Note that the file umbrello/pics/sources/accept_signal.svg was last changed in 2016, i.e. was not touched by the Qt6 port.
The offending content appears to be in the <use> starting at line 133:
    <use
       id="use3817"
       xlink:href="#(null)"

There are a few more files with the same pattern xlink:href="#(null)",
umbrello/pics/sources/accept_time_event.svg
umbrello/pics/sources/send_signal.svg
umbrello/pics/sources/umbr-message-destroy.svg

EXPECTED RESULT

The continuous integration pipeline shall not fail on the work/port_qt6_try_2 branch.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2
Umbrello version: Git branch work/port_qt6_try_2 2.38.70 (experimental) (Applications 24.11.70)

Comment 1 Ralf Habacker 2024-08-27 21:24:46 UTC

Git commit 2073a10812e558ea96d8e6661063e1a4595623bc by Ralf Habacker.
Committed on 27/08/2024 at 21:24.
Pushed by habacker into branch 'master'.

cmake: fix building svg2png with Qt5

The sv2png port to Qt5 was not finished.

M  +1    -1    maintainer/CMakeLists.txt

https://invent.kde.org/sdk/umbrello/-/commit/2073a10812e558ea96d8e6661063e1a4595623bc

Comment 2 Ralf Habacker 2024-08-27 21:31:52 UTC

(In reply to Oliver Kellogg from comment #0)
> Note that the file umbrello/pics/sources/accept_signal.svg was last changed
> in 2016, i.e. was not touched by the Qt6 port.
> The offending content appears to be in the <use> starting at line 133:
>     <use
>        id="use3817"
>        xlink:href="#(null)"
> 
> There are a few more files with the same pattern xlink:href="#(null)",
> umbrello/pics/sources/accept_time_event.svg
> umbrello/pics/sources/send_signal.svg
> umbrello/pics/sources/umbr-message-destroy.svg

After finishing the port of svg2png to Qt5, it turned out, that this issue also occurs with the Qt5 version of svg2png.

Comment 3 Ralf Habacker 2024-08-27 21:38:47 UTC

Git commit 72802bb7bf5bcbd03d49a22f585876f9c50ccc29 by Ralf Habacker.
Committed on 27/08/2024 at 21:38.
Pushed by habacker into branch 'master'.

Fix building png images from svg files caused by broken attribute 'xlink:href="#(null)"'

M  +0    -8    umbrello/pics/sources/accept_signal.svg
M  +0    -8    umbrello/pics/sources/accept_time_event.svg
M  +0    -8    umbrello/pics/sources/send_signal.svg
M  +0    -8    umbrello/pics/sources/umbr-message-destroy.svg

https://invent.kde.org/sdk/umbrello/-/commit/72802bb7bf5bcbd03d49a22f585876f9c50ccc29

Comment 4 Ralf Habacker 2024-08-28 15:23:53 UTC

Git commit 461968b265df7a861b3b0282f42180c20aef1a82 by Ralf Habacker.
Committed on 28/08/2024 at 15:23.
Pushed by habacker into branch 'release/24.08'.

Fix building png images from svg files caused by broken attribute 'xlink:href="#(null)"'
(cherry picked from commit 72802bb7bf5bcbd03d49a22f585876f9c50ccc29)

M  +0    -8    umbrello/pics/sources/accept_signal.svg
M  +0    -8    umbrello/pics/sources/accept_time_event.svg
M  +0    -8    umbrello/pics/sources/send_signal.svg
M  +0    -8    umbrello/pics/sources/umbr-message-destroy.svg

https://invent.kde.org/sdk/umbrello/-/commit/461968b265df7a861b3b0282f42180c20aef1a82

Comment 5 Ralf Habacker 2024-08-28 15:24:02 UTC

Git commit 61fc72a35b06ba3234b8728fe9f18f07eeba06a8 by Ralf Habacker.
Committed on 28/08/2024 at 15:23.
Pushed by habacker into branch 'release/24.08'.

cmake: fix building svg2png with Qt5

The sv2png port to Qt5 was not finished.
(cherry picked from commit 2073a10812e558ea96d8e6661063e1a4595623bc)
(cherry picked from commit 252b64c9e11d0f551e9323401da96da07afec0c8)

M  +1    -1    maintainer/CMakeLists.txt

https://invent.kde.org/sdk/umbrello/-/commit/61fc72a35b06ba3234b8728fe9f18f07eeba06a8