Bug 492243

Summary: At night, 7-day day/night NOAA forecasts don't fit in default System Tray popup size
Product: [Unmaintained] kdeplasma-addons Reporter: Nate Graham <nate>
Component: WeatherAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: isma.af
Priority: NOR    
Version First Reported In: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 6.2
Sentry Crash Report:
Attachments: Last day's forecast cut off

Description Nate Graham 2024-08-27 02:41:18 UTC
Created attachment 172992 [details]
Last day's forecast cut off

Current git master of everything from KDE


STEPS TO REPRODUCE
1. Set the weather widget up to show a forecast from the NOAA provider. Example: "Chicago O'Hare International Airport"
2. Wait until it's night
3. Open the widget

OBSERVED RESULT
The day forecast for the last day is cut off at the default System, Tray widget size. See attached screenshot.

EXPECTED RESULT
Either the day forecast for day 7 isn't shown, or else the layout is rejiggered so that it always does fit.
Comment 1 Ismael Asensio 2024-08-27 11:47:02 UTC
Git commit 79f77bda50e961fade362256fbbebb9443779ded by Ismael Asensio.
Committed on 27/08/2024 at 11:45.
Pushed by iasensio into branch 'wip/weather-forecast-grid'.

applets/weather: Reduce forecast layout minimum width

When the forecast has a night row, we show "Day" and "Night" labels
as the row headings. If the forecast starts at night, we can play
with the "Night" label positioning to save some horizontal space

Technically, instead of pushing fake items (placeholders) into the
model and use a spacial case on the usual delegates, add the Day/Night
labels directly to the grid. This also simplifies the delegates.

Also reduce the grid horizontal spacing to 0, as the icon margins are
enough to compensate for this
FIXED-IN: 6.2

M  +31   -15   applets/weather/package/contents/ui/ForecastView.qml
M  +2    -8    applets/weather/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/-/commit/79f77bda50e961fade362256fbbebb9443779ded
Comment 2 Ismael Asensio 2024-08-27 13:04:18 UTC
The MR isn't merged yet

I forgot to rename to a `work/` branch and that seems to have messed up bugzilla hooks closing the bug-report
Comment 3 Bug Janitor Service 2024-08-27 13:42:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/612