| Summary: | Invisible conversion rate for Bitcoin in price dialog | ||
|---|---|---|---|
| Product: | [Applications] kmymoney | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | general | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | git (master) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/office/kmymoney/-/commit/0b8f7ce918d6c439f1e6148c3f6be4d805783dc2 | Version Fixed In: | 5.2 |
| Sentry Crash Report: | |||
| Attachments: |
test case
Screenshot showing editing bitcoin currency Screenshot showing after update of conversion rate Screenshot showing price editor with zero conversion rate Screenshot showing currency editor for bitcoin with default values Screenshot showing adding new account for bitcoin using default values |
||
Created attachment 172882 [details]
Screenshot showing editing bitcoin currency
Created attachment 172883 [details]
Screenshot showing after update of conversion rate
Created attachment 172884 [details]
Screenshot showing price editor with zero conversion rate
Git commit f596aa45aa750ba5a56b01e7ee14a7893870a7f2 by Thomas Baumgart. Committed on 24/08/2024 at 06:30. Pushed by tbaumgart into branch 'master'. Fix display of price precision FIXED-IN: 5.2 M +3 -3 kmymoney/dialogs/kequitypriceupdatedlg.cpp M +8 -2 kmymoney/mymoney/storage/pricemodel.cpp https://invent.kde.org/office/kmymoney/-/commit/f596aa45aa750ba5a56b01e7ee14a7893870a7f2 Created attachment 172907 [details]
Screenshot showing currency editor for bitcoin with default values
An additional place for problems with the display of Bitcoin currencies is in the default value for the number of decimal places, which is currently 4 (see screenshot)
Created attachment 172908 [details]
Screenshot showing adding new account for bitcoin using default values
It is not possible to add an account with the Bitcoin currency and standard precision, as the conversion factor is always 0.
Edit the bitcoin entry in Tools/Currencies and set the price precision to 8. That increases the value of fractional digits for the price. Git commit 0b8f7ce918d6c439f1e6148c3f6be4d805783dc2 by Thomas Baumgart. Committed on 25/08/2024 at 09:50. Pushed by tbaumgart into branch 'master'. Increase standard price precision of Bitcoin to 8 This only has an effect if Bitcoins are currently not used in a data file. In case they are, users can use the currency editor to increase the price precision manually. M +5 -1 kmymoney/mymoney/mymoneyfile.cpp https://invent.kde.org/office/kmymoney/-/commit/0b8f7ce918d6c439f1e6148c3f6be4d805783dc2 |
Created attachment 172881 [details] test case STEPS TO REPRODUCE 1. start kmymoney from master branch 2. open appended kmymoney file 3. Click on menu "Extra" prices 4. Inspect the line containing the price for EUR->BTC OBSERVED RESULT There is a conversion rate of 0.0000 shown EXPECTED RESULT The conversion rate of 0.000018 should be shown. SOFTWARE/OS VERSIONS Linux: openSUSE Leap_15.5 KDE Frameworks Version: 5.103.0 Qt Version: 5.15.8 ADDITIONAL INFORMATION See the appended screenshots for details