Bug 491878

Summary: Modifying a saved search show more than saved
Product: [Applications] digikam Reporter: Jérôme DEMEULLE <jdemeulle.photo>
Component: Searches-AdvancedAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: metzpinguin
Priority: NOR    
Version First Reported In: 8.4.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/-/commit/d0074abf1e0fba305544f579a6dd005556f10fe1 Version Fixed/Implemented In: 8.5.0
Sentry Crash Report:

Description Jérôme DEMEULLE 2024-08-18 23:50:59 UTC 
SUMMARY
The panel modifying a (advanced) saved search  show more than the search previously saved

STEPS TO REPRODUCE
1. defined one advanced search with several group (take 3 groups) and save it 
2. defined another advanced search with several group (take 4 groups) and save it the a name who will be after the first saved search in alphabetical order.
3.  (I have several  saved search but it should failed with two) 
4. Click the first saved search and modify it

OBSERVED RESULT
It shows the 3 origing groups and another group that come from the second saved search

EXPECTED RESULT
It should show only the content saved, not mixing with the second saved search

SOFTWARE/OS VERSIONS
Windows: Windows 10 Version 22H2 (x86_64)

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2024-08-19 06:03:53 UTC 
When you select a saved search, it is not automatically the "Current" search. To edit a saved search, there is a context menu above the saved search.

Maik
Comment 2 Jérôme DEMEULLE 2024-08-19 10:50:32 UTC 
(In reply to Maik Qualmann from comment #1)
> When you select a saved search, it is not automatically the "Current"
> search. To edit a saved search, there is a context menu above the saved
> search.
> 
> Maik

Hi Maik, thanks for your answer. 
When I edit a saved search, I'm using the button "Modify the saved search" just above the list of saved search and it's nto showing the exact content of the saved search (but the search works fine, it seems it just the display which is false).
To reproduce the bug, try first to edit the second saved search (the one with 4 groups) cancel it and edit the first saved search (with less group than the previous edit) and it show more groups than the effect search
Comment 3 Maik Qualmann 2024-08-19 16:39:47 UTC 
And this button is wrong. You have to use the right mouse button context menu to edit a saved search. The button above the list is used to edit the current search and then save new searches.

Maik
Comment 4 Maik Qualmann 2024-08-19 16:52:27 UTC 
Git commit d0074abf1e0fba305544f579a6dd005556f10fe1 by Maik Qualmann.
Committed on 19/08/2024 at 16:51.
Pushed by mqualmann into branch 'master'.

reset search view for the edit button
FIXED-IN: 8.5.0

M  +1    -0    core/utilities/searchwindow/searchtabheader.cpp

https://invent.kde.org/graphics/digikam/-/commit/d0074abf1e0fba305544f579a6dd005556f10fe1
Comment 5 Maik Qualmann 2024-08-19 16:53:28 UTC 
OK, you were right. I had overlooked the edit button. I always use the context menu.

Maik
Comment 6 Jérôme DEMEULLE 2024-08-19 17:00:26 UTC 
(In reply to Maik Qualmann from comment #5)
> OK, you were right. I had overlooked the edit button. I always use the
> context menu.
> 
> Maik

Thank you for this correction. I will user yr way until the next 8.5