Bug 491870

F2 works normally here under Linux and Windows and opens the slideshow settings.
In the bottom toolbar in the slideshow, the last tool button should also open the settings.

Maik

(In reply to Maik Qualmann from comment #1)
> F2 works normally here under Linux and Windows and opens the slideshow
> settings.
> In the bottom toolbar in the slideshow, the last tool button should also
> open the settings.
> 
> Maik
On mac OS there is no bottom toolbar in the slideshow (maybe this is exactly what I have deactivated in the settings?). All shortcuts (with the exception of F1) seems not working on mac OS - respectively the shortcuts of digikam are executed and not those of the slideshow.

Under my Macbook Pro M1 the Slideshow Toolbar work as expected :

https://i.imgur.com/ipM0iCa.jpg

And the button on the right side of the tool bar allow to show Slideshow settings dialog.

But i agree that the F2 key under MacOS show the advanced rename dialog while slideshow running.

Gilles Caulier

I suspect the cause is the "native" menu bar in macOS, which is also active when another window is opened in full screen.

1. We could not use the native menu bar, but I don't think any macOS user wants that.

2. We could try to disable the menu bar while the slideshow is open.

3. We could use other keyboard shortcuts that are not used in the slideshow.

Maik

(In reply to caulier.gilles from comment #3)
> Under my Macbook Pro M1 the Slideshow Toolbar work as expected :
> 
> https://i.imgur.com/ipM0iCa.jpg
> 
> And the button on the right side of the tool bar allow to show Slideshow
> settings dialog.
> 
> But i agree that the F2 key under MacOS show the advanced rename dialog
> while slideshow running.
> 
> Gilles Caulier
Yes. Can you please open the settings with that button and the uncheck the option "show progress indicator"? Then the tool bar is no longer visible and you ano longer have a chance to reach the settings....

Simplest solution: add a new menu entry "Slideshow settings..." in the submenu "Slideshow". So you can reach the settings in any case

Hi Maik,

In my Apple computer, the system bar on the top is only active when i move mouse on the top, else it's hidden. Not that when slideshow run, the widget is well switched to full-screen.

Gilles

Right about 3/ : another keyboard shortcut must be used for the plugin settings dialog...

Gilles

Maik,

If the F2 do not work in SlideShow from MacOS and works as expected under Linux, i suspect a wrong focus set to the tool. The icon-view remain the lead focus which catch the shorcut event.

Gilles

Gilles,

If you click on the slideshow toolbar with the mouse, does F2 work?

Maik

Hi Maik,

Not at all, set the focus on the slide canvas or the tool bar do not change anything. Advanced Rename still open with F2.

Gilles

Starting Slideshow from the play button overlay in icon view, or from the View sub menu, do not change anything.

Gilles

The F1 key works as expected, the help dialog appear, but not F2. There is nothing special to read in the console while slideshow is running.

Gilles

The F1 key is not used in the main menu. As I said, I suspect that the native main menu is always active under macOS and catches all input keys first when the application is active.

What happens when F4 is pressed in the slideshow?

Maik

While Slideshow, F4 open the image editor in a separated view (full-screen).

Gilles

Git commit fbb59efcacf397455b0f9af96eb74a4e42983809 by Maik Qualmann.
Committed on 08/09/2024 at 07:25.
Pushed by mqualmann into branch 'master'.

try to fix key shortcuts in the slideshow tool

M  +6    -0    core/app/main/digikamapp_setup.cpp

https://invent.kde.org/graphics/digikam/-/commit/fbb59efcacf397455b0f9af96eb74a4e42983809

@Gilles, is this problem still reproducible?

Maik

Yes, it still the same for Intel or Arm versions. F2 launch the advanced rename tool.

Gilles

Git commit b75b9e1f907c320523a1e30541b1c8d48938407a by Maik Qualmann.
Committed on 15/09/2024 at 07:09.
Pushed by mqualmann into branch 'master'.

try with Qt::WindowShortcut

M  +5    -5    core/app/main/digikamapp_setup.cpp

https://invent.kde.org/graphics/digikam/-/commit/b75b9e1f907c320523a1e30541b1c8d48938407a

Maik, same problems with last patch under macOS arm64.

Git commit ddb0bdf055d542e0f2eae8d49dc5c6dc370705e4 by Maik Qualmann.
Committed on 15/09/2024 at 08:14.
Pushed by mqualmann into branch 'master'.

last try with Qt::WidgetShortcut

M  +5    -5    core/app/main/digikamapp_setup.cpp

https://invent.kde.org/graphics/digikam/-/commit/ddb0bdf055d542e0f2eae8d49dc5c6dc370705e4

Maik, same result with your last commit. It's time to assign specific shortcuts in Slideshow ?

Yes, specific keyboard shortcuts for the slideshow is the best solution at the moment.

Maik

Git commit 898044fab80f1e5d3737fb955fa72ee3b81d9106 by Gilles Caulier.
Committed on 17/09/2024 at 08:47.
Pushed by cgilles into branch 'master'.

Change F2 to Alt+P and F4 to Alt+Y as keys sequence to handle configuration dialog and overlay visibility in SlideShow tool

M  +10   -7    core/dplugins/generic/view/slideshow/common/slideshowloader.cpp
M  +2    -2    core/dplugins/generic/view/slideshow/slideshowplugin.cpp
M  +50   -62   core/dplugins/generic/view/slideshow/widgets/slidetoolbar.cpp

https://invent.kde.org/graphics/digikam/-/commit/898044fab80f1e5d3737fb955fa72ee3b81d9106

Git commit 5fdf00e20991982b129b42504f4cb9b44eba4902 by Gilles Caulier.
Committed on 17/09/2024 at 08:51.
Pushed by cgilles into branch 'master'.

fix manual about Slideshow keyboard shortcuts
FIXED-IN: 8.5.0

M  +2    -2    slideshow_tools/slide_tool.rst

https://invent.kde.org/documentation/digikam-doc/-/commit/5fdf00e20991982b129b42504f4cb9b44eba4902