Bug 491693

Summary:	When adding a Flatpak new repo via a flatpakref file from a repo not already on the system, Discover presents it as an Error
Product:	[Applications] Discover	Reporter:	Wing Hong Chan <winghongchan>
Component:	discover	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED UPSTREAM
Severity:	minor	CC:	aleixpol, nate
Priority:	NOR
Version First Reported In:	6.1.3
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot of said "Error" dialog

Description Wing Hong Chan 2024-08-14 00:58:00 UTC

Created attachment 172603 [details]
Screenshot of said "Error" dialog

SUMMARY
When I open a .flatpakref in Discover and try to install the app (and it’s my first time installing an app from the repo), Discover shows an Error message to say that it’s adding a remote repository. The problem is, the task of adding a repo is not an error so the dialog should not read “Error” at the top. 

STEPS TO REPRODUCE
1. Download the .flatpakref for Obliviate (from Elementary AppCenter) by clicking “Download as Flatpak” on https://appcenter.elementary.io/com.github.elfenware.obliviate/
2. Open the .flatpakref file using Discover. 
3. Click “Install from AppCenter”. 

OBSERVED RESULT
Error message appears, but once you authenticate (if necessary, to let your computer add the repo) the app installs successfully.

EXPECTED RESULT
Perhaps the message should be shown in a Kirigami passive notification, or at least something less error-y than a dialog that says “Error”. 

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: Fedora Linux 40
KDE Plasma Version: 6.1.3
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.2

ADDITIONAL INFORMATION
I left the platform unspecified because I'm not sure. I'm just using Discover the way it is included with Fedora KDE.

Comment 1 Nate Graham 2024-08-14 21:46:12 UTC

So to be clear, it successfully added the repo?

Comment 2 Wing Hong Chan 2024-08-14 22:12:45 UTC

(In reply to Nate Graham from comment #1)
> So to be clear, it successfully added the repo?

Yes it successfully added the AppCenter repo and installed Obliviate.

Comment 3 Nate Graham 2024-08-21 15:38:07 UTC

Thanks, can reproduce the issue.

Comment 4 Nate Graham 2024-09-19 13:21:44 UTC

This seems to be fixed for me now; I guess flatpak itself was at fault, and that got fixed recently.