| Summary: | System tray icon of Onboard (on-screen keyboard) not visible after upgrading to 6.1.4 | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Guilherme Silva <oguilherme> |
| Component: | System Tray | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fanzhuyifan, kde, materka, nate |
| Priority: | NOR | Keywords: | regression |
| Version: | 6.1.4 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/dec0608369e1fe50685ce94113681ec9ed1bc43c | Version Fixed In: | 6.1.5 |
| Sentry Crash Report: | |||
|
Description
Guilherme Silva
2024-08-10 05:37:24 UTC
I think this should be reported to onboard as onboard is responsible for not showing the decorations that allows users to terminate the program, thus removing the status icon. I'm sorry, there must be a misunderstanding on your part because I'm failing to understand how this is Onboard's fault... A lot of other popular programs also "minimize to tray" when you close them (e.g. Discord, KeepassXC, qBittorrent). Besides, this functionality from Onboard worked just fine from KDE 5.x through 6.1.3. Lastly, Onboard as a project is also pretty much "dead" (last commit was 7 years ago), so even if this had to be fixed on their side, I don't think it will be... (In reply to Guilherme Silva from comment #2) > A lot of other popular programs also "minimize to tray" when you close them > (e.g. Discord, KeepassXC, qBittorrent). These programs (steam, slack) work on my end. Basically it's the app's responsibility to not quit when the window close button is clicked, and there is nothing kwin/plasma could do if the onboard decides just to exit when the closed button is clicked. > Lastly, Onboard as a project is also pretty much "dead" (last commit was 7 > years ago), so even if this had to be fixed on their side, I don't think it > will be... That's unfortunate but does not change the fact that a change is needed on their side.. If you are interested, maybe you could investigate and submit a patch to onboard? (In reply to fanzhuyifan from comment #3) > These programs (steam, slack) work on my end. Sure, but I'm pretty sure they don't rely on the GtkStatusIcon spec, like I mentioned in my initial post... > Basically it's the app's responsibility to not quit when the window close button is clicked, and > there is nothing kwin/plasma could do if the onboard decides just to exit > when the closed button is clicked. Sure, but that's not the issue here. Before 6.1.4, just by launching Onboard, an icon would be added to systray. After 6.1.4, that doesn't happen... > That's unfortunate but does not change the fact that a change is needed on > their side.. If you are interested, maybe you could investigate and submit a > patch to onboard? No, thanks, that would be rather pointless since the last commit was 7 years ago. I do want to bisect this on KDE's side because this seems like a regression to me. However, KDE has a lot of subprojects and I'm not sure which one handles the system tray stuff. Can you give me some pointers? Thank you. Alright, so that was easier than expected: I just manually downgraded KWin to 6.1.3 and I got the tray icon back. I'll do some bisecting next. Just a small correction from my last email: The regression is in plasma-workspace, not KWin. Here's the git bisect log between 6.1.3 (good) and 6.1.4 (bad): >$ git bisect log >git bisect start ># status: waiting for both good and bad commits ># good: [0923ed4c15e3ef93c07bf63fc066256b0d7b736b] update version for new release >git bisect good 0923ed4c15e3ef93c07bf63fc066256b0d7b736b ># status: waiting for bad commit, 1 good commit known ># bad: [b3d45d67ac99c4885646bccf9acc3db68005ba53] update version for new release >git bisect bad b3d45d67ac99c4885646bccf9acc3db68005ba53 ># good: [a26bf08fbca2c527c1eeedec32de9555f8fdcdf0] GIT_SILENT Sync po/docbooks with svn >git bisect good a26bf08fbca2c527c1eeedec32de9555f8fdcdf0 ># bad: [a70f71378eda8905ca5a160c1cea5b6cb2359bbd] GIT_SILENT Sync po/docbooks with svn >git bisect bad a70f71378eda8905ca5a160c1cea5b6cb2359bbd ># bad: [2092fe8f2fada49ce23a52be722866c8cd98911d] Track screen change >git bisect bad 2092fe8f2fada49ce23a52be722866c8cd98911d ># bad: [bf145579129e363cf14064bb369260c303b9ae23] xembed-sni-proxy: Check if descendant windows want button events >git bisect bad bf145579129e363cf14064bb369260c303b9ae23 ># good: [efca5810412709f3fda40c5eb75d024752b581fc] GIT_SILENT Sync po/docbooks with svn >git bisect good efca5810412709f3fda40c5eb75d024752b581fc ># first bad commit: [bf145579129e363cf14064bb369260c303b9ae23] xembed-sni-proxy: Check if descendant windows want button events Here's the link of the commit for easier assessment: https://invent.kde.org/plasma/plasma-workspace/-/commit/bf145579129e363cf14064bb369260c303b9ae23 Lastly, I kindly ask developers to reevaluate this bug report whenever possible. Thanks. I checked out efca5810412709f3fda40c5eb75d024752b581fc and I dont get an icon I checkout out v6.1.3 and dont get an icon either bf145579129e363cf14064bb369260c303b9ae23 braking it would have surprised me. I noticed that onboard is running wayland natively here, so of course xembed GTKStatusIcon cant work After forcing to x11 with GDK_BACKEND=x11 I notice xembed-sni-proxy crashes. A workaroung is using appindicator for its status icon A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4601 Git commit 85eb56e174bf887ccb8311e8f1a871e1ec453e04 by David Redondo. Committed on 13/08/2024 at 07:39. Pushed by davidre into branch 'master'. xembedsniproxy: Guard against crash when xcb_query_tree_reply is null FIXED-IN:6.1.5 M +3 -0 xembed-sni-proxy/sniproxy.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/85eb56e174bf887ccb8311e8f1a871e1ec453e04 Git commit dec0608369e1fe50685ce94113681ec9ed1bc43c by David Redondo. Committed on 13/08/2024 at 09:09. Pushed by davidre into branch 'Plasma/6.1'. xembedsniproxy: Guard against crash when xcb_query_tree_reply is null FIXED-IN:6.1.5 (cherry picked from commit 85eb56e174bf887ccb8311e8f1a871e1ec453e04) Co-authored-by: David Redondo <kde@david-redondo.de> M +3 -0 xembed-sni-proxy/sniproxy.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/dec0608369e1fe50685ce94113681ec9ed1bc43c |