| Summary: | Initial kritarc File Incomplete and Sets Wrong Defaults For New (and possibly upgrading) Users | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Flash <michel.r.bergeron> |
| Component: | General | Assignee: | Halla Rempt <halla> |
| Status: | RESOLVED LATER | ||
| Severity: | normal | CC: | halla, penguinflyer2222 |
| Priority: | NOR | ||
| Version First Reported In: | 5.2.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | kritarc file diff - after opening Settings window | ||
Confirming that there is an inconsistency in the Move Tool's Force Instant Preview default, caused by commit 16ab0b72 having changed the preferences dialog's default (in kis_dlg_preferences.cc PerformanceTab::load()) without changing the tool's default (in kis_tool_move.cc KisToolMove::startStrokeImpl()). According to that, the intended default is 'false'. I thought we probably should remove the kritarc file, since kisconfig has a defaults system anyway. Then I updated this morning, and I saw that krita/data/kritarc already had been removed, but I cannot find any relevant commit. Git commit 1354a32d25227a0f11b2cbd6c2f5046dabe4fe04 by Halla Rempt. Committed on 17/10/2024 at 09:36. Pushed by rempt into branch 'master'. Store the default LoD mode for the move tool in kritarc M +2 -0 krita/data/kritarc https://invent.kde.org/graphics/krita/-/commit/1354a32d25227a0f11b2cbd6c2f5046dabe4fe04 Git commit d2f533594f3b8d31525cc05b51c79ea20108998a by Halla Rempt. Committed on 17/10/2024 at 09:44. Pushed by rempt into branch 'master'. Change the default lod mode for the move tool to false This also needs to be changed in the tool itself. M +1 -1 plugins/tools/basictools/kis_tool_move.cc https://invent.kde.org/graphics/krita/-/commit/d2f533594f3b8d31525cc05b51c79ea20108998a This should be consistent in all three places now: kritarc, tool and preferences dialog... As for the other differences between kritarc and default values set everywhere, that's pretty much humanly impossible to sanitize without rewriting the config system from scratch (which was started, once, but that developer disappeared without a word.) I'm going to resolve this report to Later now. |
Created attachment 172273 [details] kritarc file diff - after opening Settings window SUMMARY On new installations of Krita 5.2.x, the kritarc file generated is missing config entries, leading to incorrect defaults. It's most apparent on brand new deployments, but somehow occurred for me when upgrading from 5.2.2 to 5.2.3 on Windows 11 as well. Opening the Configure Krita window & clicking OK (without changing any settings) results in missing default flags being added to the kritarc file. Clicking Cancel does nothing as expected. Exacerbating this, it seems like some tools' default behaviors (if the config flag is not present in kritarc) are different from the intended defaults as shown to the user in Configure Krita. This leads to some settings behaving differently for brand new users vs those who've gone in and played around with unrelated options. Most noticeably, on a brand new installation of Krita, Force Instant Preview is toggled on for the Move tool; but after clicking OK (without changing any settings), it is toggled off. "Off" is clearly the intended default, as that's what is shown to the user when they check that setting. This behavior was observed in Windows 10, Windows 11, as well as the Linux AppImage. STEPS TO REPRODUCE 1. Delete or move the kritarc file. Optionally you can delete/move the ~/.local/share/krita folder to simulate a new install. 2. Open Krita. 3. Make a new large document where you can observe Instant Preview in action: 3a. Create an A3 300ppi document (3508 x 4960) 3b. Draw something on a new layer 3c. Zoom out to about 10% 3d. Select the Move tool, and begin moving the layer (a green box will appear) 3e. Zoom in (50+%) while the tool is still active, and notice that the preview quality is extremely low while Instant Preview is active for the Move Tool 4. Cancel the Move operation by pressing Esc (the layer should return to normal quality) 5. Open Settings > Configure Krita 6. Click OK without doing or changing anything 7. Retry the Move tool from step 3 and notice that Instant Preview is no longer active for the Move tool OBSERVED RESULT Before clicking OK in the Configure Krita window, Force Instant Preview is enabled for the Move tool, despite the default selection in Performance > Instant Preview > Force Instant Preview for Move Tool being unchecked. EXPECTED RESULT Force Instant Preview should be off for the Move tool, unless a user explicitly toggles it on. Opening and confirming the Settings window, without changing any settings, should not result in any changed settings. SOFTWARE/OS VERSIONS Windows: 10 and 11 Linux/KDE Plasma: Linux Mint 21.3 Cinnamon ADDITIONAL INFORMATION I attached a full diff of my kritarc file from testing on Linux (easier). The "before" is from opening Krita for the first time, where all I did was create and save a document (simulating a new user). The "after" represents me opening the Configure Krita window and immediately clicking OK to close it. Doing this adds a lot of entries to the file, and changes some tools' behaviors. I was not able to reproduce the 5.2.2 > 5.2.3 upgrade re-enabling the Force Instant Preview for Move Tool issue on Linux, but upgrading about a month ago on Windows 11 is what led me down this rabbit hole in the first place.