| Summary: | Adding global suppression in diagnostics crash Kate | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Eduardo <sollericos> |
| Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | christoph |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | 23.08.5 | ||
| Target Milestone: | --- | ||
| Platform: | Slackware | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/-/commit/ddb4a1b6ceefb4d8b069fe14440263d0bb776bd8 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Eduardo
2024-08-03 08:49:04 UTC
Could you try a more recent version? We did patch a lot in the last year. 🐛🧹 ⚠️ This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information, then set the bug status to REPORTED. If there is no change for at least 30 days, it will be automatically closed as RESOLVED WORKSFORME. For more information about our bug triaging procedures, please read https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging. Thank you for helping us make KDE software even better for everyone! I've tried today's AppImage (kate-master-7758-linux-gcc-x86_64.AppImage) and the behavior is the same, but less important in both versions. When I add a global suppression to a message (for example: "[texlab] Unused label") it disappears in that document, not in the rest of documents. So, when I try to do the same in other closed documents, kate dies. If I open the next documents before trying to add the same global suppression, the message suddenly disappears for that document (not the others). I don't know if it makes sense to clean all "[texlab] Unused label" messages in the diagnostics screen whenever a global suppression is added. If it's not possible, it's OK for me. Now I understand how it works and this issue can be closed because there is a workaround for not killing Kate accidentally. A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1567 Git commit ddb4a1b6ceefb4d8b069fe14440263d0bb776bd8 by Christoph Cullmann, on behalf of Waqar Ahmed. Committed on 25/08/2024 at 16:39. Pushed by cullmann into branch 'master'. Fix adding global suppression doesn't suppress existing diagnostics We need to scan all the document nodes once global suppression changes to suppress all matches. Also, try not to rely on Document pointer, we can have diagnostics for files which are not open in the editor. M +5 -13 apps/lib/diagnostics/diagnostic_suppression.h M +32 -9 apps/lib/diagnostics/diagnosticview.cpp https://invent.kde.org/utilities/kate/-/commit/ddb4a1b6ceefb4d8b069fe14440263d0bb776bd8 |