| Summary: | Show understandable device names in applet | ||
|---|---|---|---|
| Product: | [Plasma] plasma-pa | Reporter: | gudvinr+kde |
| Component: | applet | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | isma.af, me, nate, sitter |
| Priority: | NOR | ||
| Version: | 6.1.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-pa/-/commit/eae94ed4f1eb62276fd27c4477347efe17127d90 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
gudvinr+kde
2024-08-03 08:08:11 UTC
The underlying problem here is that there are multiple sources of device names, and all of them are bad for some devices. Trying to find one source that works for everything appears to be a fool's errand, unfortunately. For Plasma 6.2, we're going to let you choose your preferred source, and also override any of them with a custom name. See https://invent.kde.org/plasma/plasma-pa/-/merge_requests/271. *** Bug 491206 has been marked as a duplicate of this bug. *** (In reply to Nate Graham from comment #1) > The underlying problem here is that there are multiple sources of device > names, and all of them are bad for some devices. Trying to find one source > that works for everything appears to be a fool's errand, unfortunately. Pipewire uses "node.description" key for representing devices. It looks like it's the case for systemsettings too. Not sure what was the reason to use "node.nick" instead, especially when "description" key labeled as "localized human readable node one-line description" in their docs. For all of my devices, "node.nick" either the same as "node.description" or some hardware ID which isn't very "human readable" or just missing. Some other projects that I am aware of, e.g. helvum (see https://gitlab.freedesktop.org/pipewire/helvum/-/commit/fe05282f5afe4148dedf941df75c50f1c4646916) and easyeffects also prefer description field over nick. > For Plasma 6.2, we're going to let you choose your preferred source, and also override any of them with a custom name. See https://invent.kde.org/plasma/plasma-pa/-/merge_requests/271. This MR looks way too technical for a user. People might not know (nor should) what the heck ALSA is or why these "sources" even exist. IMO, sticking to single source and adding pencil icon for them to set up their own name will be simple than that. And, more importantly, it is simple concept that needs no explanation. Git commit eae94ed4f1eb62276fd27c4477347efe17127d90 by Harald Sitter. Committed on 31/08/2024 at 02:40. Pushed by sitter into branch 'master'. allow user to rename devices and select a preferred name source # Name Source Allows choosing the name out of a set number of sources. Names have been unified across applet and kcm now. Changes here are instantly applied throughout the stack. # Overrides Additionally, overrides may be set. These override all supported name fields so it doesn't matter which name source is chosen at the time the change is made. The override installs a wireplumber json file and restarts the stack to apply the change. Related: bug 487658, bug 488897 M +6 -1 applet/contents/ui/main.qml M +3 -0 src/CMakeLists.txt A +66 -0 src/devicenamesourcemodel.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +27 -0 src/devicenamesourcemodel.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +141 -0 src/devicerenamemodel.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +30 -0 src/devicerenamemodel.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +320 -0 src/devicerenamesaver.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +49 -0 src/devicerenamesaver.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] M +10 -0 src/globalconfig.kcfg M +1 -0 src/globalconfig.kcfgc M +17 -1 src/kcm/ui/DeviceListItem.qml A +267 -0 src/kcm/ui/RenameDevices.qml [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] M +10 -0 src/kcm/ui/main.qml M +14 -0 src/qml/plugin.cpp https://invent.kde.org/plasma/plasma-pa/-/commit/eae94ed4f1eb62276fd27c4477347efe17127d90 |