Summary: | Apps with single non-SPDX license in their <project_license> tag display it with its first letter cut off | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
Component: | discover | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleixpol, ngompa13 |
Priority: | NOR | ||
Version: | 6.1.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/4edc093462d867084bca5ea1de708878bae2e4cf | Version Fixed In: | 6.1.4 |
Sentry Crash Report: | |||
Attachments: | license for Drawf Fortress shown as "warf Fortress" instead of "Dwarf Fortress" |
Description
Nate Graham
2024-08-02 15:31:48 UTC
That last one looks like it has a different bug where it isn't handling the license expression operators properly. Yes, there should be a comma between GPL-3.0 and Proprietary. That's on my short-term to-do list. Git commit 8da80c819b79890e439af24835c73765784effda by Nate Graham. Committed on 02/08/2024 at 16:34. Pushed by ngraham into branch 'master'. Separate licenses in header with commas Otherwise they visually blend together, which may result in a display of licenses that's misleading. M +6 -0 discover/qml/ApplicationPage.qml https://invent.kde.org/plasma/discover/-/commit/8da80c819b79890e439af24835c73765784effda A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/891 Git commit 1b9b314aeb4eab49ca6cb93abcc22c79a85dfd6c by Nate Graham. Committed on 02/08/2024 at 23:14. Pushed by ngraham into branch 'master'. Only chop off leading @ from tokenized license text if needed Apparently at some point in the past, tokenized non-SPDX license labels got prefixed with "@". As a result, the code unconditionally chopped off the first character. At some point, tokenizing stopped always doing that, causing some license labels to be shown with their first letter missing. I don't know if the prepending might come back in the future, so to be safe, let's only conditionally remove the first character if it's "@". FIXED-IN: 6.1.4 M +7 -1 libdiscover/appstream/AppStreamUtils.cpp https://invent.kde.org/plasma/discover/-/commit/1b9b314aeb4eab49ca6cb93abcc22c79a85dfd6c Git commit 4edc093462d867084bca5ea1de708878bae2e4cf by Nate Graham. Committed on 02/08/2024 at 23:33. Pushed by ngraham into branch 'Plasma/6.1'. Only chop off leading @ from tokenized license text if needed Apparently at some point in the past, tokenized non-SPDX license labels got prefixed with "@". As a result, the code unconditionally chopped off the first character. At some point, tokenizing stopped always doing that, causing some license labels to be shown with their first letter missing. I don't know if the prepending might come back in the future, so to be safe, let's only conditionally remove the first character if it's "@". FIXED-IN: 6.1.4 (cherry picked from commit 1b9b314aeb4eab49ca6cb93abcc22c79a85dfd6c) Co-authored-by: Nate Graham <nate@kde.org> M +7 -1 libdiscover/appstream/AppStreamUtils.cpp https://invent.kde.org/plasma/discover/-/commit/4edc093462d867084bca5ea1de708878bae2e4cf |