Bug 491007

Summary: When Undo is scrolled over the undo choices do not appear
Product: [Applications] digikam Reporter: Tom Cunningham <twcunningham627>
Component: ImageEditor-UndoAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: metzpinguin
Priority: NOR    
Version First Reported In: 8.4.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/-/commit/02aaf4673f45bcb220f188135b7f25cf338b93a1 Version Fixed In: 8.5.0
Sentry Crash Report:

Description Tom Cunningham 2024-07-30 02:58:29 UTC 
SUMMARY
In the Image Editor, under the Edit menu item, when "Undo" is scrolled over, no undo choices are displayed.

STEPS TO REPRODUCE
1.  Start Image Editor on an image
2. Perform a series of modifications on the image (free rotation, local contrast, color correction, etc.)
3. Select the Edit menu item and scroll over the Undo selection.

OBSERVED RESULT
The undo stack does not pop up to allow selection of a particular undo sequence.


EXPECTED RESULT
In versions previous to 8.2, the undo stack would pop up to allow selection of a particular undo sequence.


SOFTWARE/OS VERSIONS
Windows: 11 Pro Version 22H2
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 6

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2024-07-30 05:55:19 UTC 
We use a KToolBarPopupAction for this function. According to the documentation, the popup menu is only available on a toolbar; in a menu it is a normal action. So we have to replace KToolBarPopupAction with something else, e.g. KActionMenu or similar.

It also affects the album history function in the digiKam main menu.

Maik
Comment 2 Maik Qualmann 2024-07-30 06:21:39 UTC 
Git commit 02aaf4673f45bcb220f188135b7f25cf338b93a1 by Maik Qualmann.
Committed on 30/07/2024 at 06:20.
Pushed by mqualmann into branch 'master'.

activate the popup in the menu of a KToolBarPopupAction
FIXED-IN: 8.5.0

M  +1    -1    NEWS
M  +4    -0    core/app/main/digikamapp_setup.cpp
M  +4    -0    core/utilities/imageeditor/editor/editorwindow.cpp

https://invent.kde.org/graphics/digikam/-/commit/02aaf4673f45bcb220f188135b7f25cf338b93a1