| Summary: | Notification popup can be too narrow to accommodate multiple buttons with long text | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Oleg <oleg> |
| Component: | Notifications | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | andreq11s, dobrovvvvvvvv, kde, kdedev, nate |
| Priority: | NOR | ||
| Version: | 6.1.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/347b4bf2fae390f858cdf780d35ea77fbc705ac2 | Version Fixed In: | 6.2.0 |
| Sentry Crash Report: | |||
| Attachments: | Dolphin copying notification | ||
Oops. The popup should probably become wider to accommodate longer-than-expected button text. Ok, so the problem here is that the popup width is hardcoded in Globals.qml. That's not a minimum or maximum size, it's just the size, period. We should probably make that a minimum size, and allow the buttons to force individual popups to become wider if needed. *** Bug 491071 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4598 Git commit 347b4bf2fae390f858cdf780d35ea77fbc705ac2 by Nate Graham, on behalf of Arjen Hiemstra. Committed on 30/08/2024 at 20:02. Pushed by ngraham into branch 'master'. applets/notifications: Base popup width on content width This removes the fixed width constraint of notification popups, instead basing the width on its content width. It uses the old popup width as minimum width and allows the popup to expand to a maximum width that is currently defined as 3 * the minimum width, unless the screen is smaller in which case it will be limited to screen size. This allows the popup to better accomodate large or many actions. min max width M +3 -0 applets/notifications/package/contents/ui/NotificationItem.qml M +9 -1 applets/notifications/package/contents/ui/NotificationPopup.qml M +4 -6 applets/notifications/package/contents/ui/global/Globals.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/347b4bf2fae390f858cdf780d35ea77fbc705ac2 *** Bug 496470 has been marked as a duplicate of this bug. *** and in which update has this error been fixed? The bug is closed, but this error is still in the KDE Plasma Version: 6.2.3KDE Frameworks Version: 6.8.0Qt Version: 6.7.2 Out of curiosity, does it go away if you use the default Breeze Plasma theme? If so, it's an error in your custom theme, or how we handle it. And in either case, that would be a different issue (so if so, I'll re-open your bug report that I just marked as a duplicate of this one). (In reply to Nate Graham from comment #8) > Из любопытства, исчезнет ли это, если вы используете тему Breeze Plasma по > умолчанию? Если да, то это ошибка в вашей пользовательской теме или в том, > как мы с ней справляемся. И в любом случае это будет другая проблема (и если > да, то я повторно открою ваш отчет об ошибке, который я только что отметил > как дубликат этого). When using the Breeze Plasma theme, the error does not disappear, this error appears if you increase the font at least by one unit, I indicated this in the bug report Bug 496470 that I created, but you marked it as a duplicate of this bug, but this is another bug. My bug only appears when the font is enlarged, with any theme. If the font is left as default, then the notification is of normal size, but then the entire text is very small on my monitor. And scaling doesn't suit me. I downloaded three files from this link https://invent.kde.org/plasma/plasma-workspace/-/commit/347b4bf2fae390f858cdf780d35ea77fbc705ac2 and replaced them in my system, it helped. If you are truly using Plasma 6.2, the files from that merge request should already be on your computer. If they were not, then you're not really using Plasma 6.2, or your distro patched them out, or else something else strange is going on with local packages. But since we have confirmation from you that the files from that merge request fix it, this is in fact a confirmation that the fix in Plasma 6.2 works as expected. 😁 |
Created attachment 171844 [details] Dolphin copying notification SUMMARY When button label text exceeds label width it becomes cropped, which is clearly visible on Russian locale. STEPS TO REPRODUCE 1. Run Plasma with Russian locale 2. Invoke notification with buttons (for example by copying file in dolphin) OBSERVED RESULT The label on "Cancel" button is cropped and the button itself exceeds notification width. EXPECTED RESULT They should not? Although I can't come up with good solution in this situation. Operating System: Arch Linux KDE Plasma Version: 6.1.3 KDE Frameworks Version: 6.4.0 Qt Version: 6.7.2 Kernel Version: 6.10.0-3-cachyos (64-bit) Graphics Platform: Wayland Processors: 8 × Intel® Core™ i7-7700K CPU @ 4.20GHz Memory: 15.6 ГиБ of RAM Graphics Processor: AMD Radeon RX 6700 XT