Summary: | Notification popup can be too narrow to accommodate multiple buttons with long text | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Oleg <oleg> |
Component: | Notifications | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andreq11s, kde, kdedev, nate |
Priority: | NOR | ||
Version: | 6.1.3 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/347b4bf2fae390f858cdf780d35ea77fbc705ac2 | Version Fixed In: | 6.2.0 |
Sentry Crash Report: | |||
Attachments: | Dolphin copying notification |
Oops. The popup should probably become wider to accommodate longer-than-expected button text. Ok, so the problem here is that the popup width is hardcoded in Globals.qml. That's not a minimum or maximum size, it's just the size, period. We should probably make that a minimum size, and allow the buttons to force individual popups to become wider if needed. *** Bug 491071 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4598 Git commit 347b4bf2fae390f858cdf780d35ea77fbc705ac2 by Nate Graham, on behalf of Arjen Hiemstra. Committed on 30/08/2024 at 20:02. Pushed by ngraham into branch 'master'. applets/notifications: Base popup width on content width This removes the fixed width constraint of notification popups, instead basing the width on its content width. It uses the old popup width as minimum width and allows the popup to expand to a maximum width that is currently defined as 3 * the minimum width, unless the screen is smaller in which case it will be limited to screen size. This allows the popup to better accomodate large or many actions. min max width M +3 -0 applets/notifications/package/contents/ui/NotificationItem.qml M +9 -1 applets/notifications/package/contents/ui/NotificationPopup.qml M +4 -6 applets/notifications/package/contents/ui/global/Globals.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/347b4bf2fae390f858cdf780d35ea77fbc705ac2 |
Created attachment 171844 [details] Dolphin copying notification SUMMARY When button label text exceeds label width it becomes cropped, which is clearly visible on Russian locale. STEPS TO REPRODUCE 1. Run Plasma with Russian locale 2. Invoke notification with buttons (for example by copying file in dolphin) OBSERVED RESULT The label on "Cancel" button is cropped and the button itself exceeds notification width. EXPECTED RESULT They should not? Although I can't come up with good solution in this situation. Operating System: Arch Linux KDE Plasma Version: 6.1.3 KDE Frameworks Version: 6.4.0 Qt Version: 6.7.2 Kernel Version: 6.10.0-3-cachyos (64-bit) Graphics Platform: Wayland Processors: 8 × Intel® Core™ i7-7700K CPU @ 4.20GHz Memory: 15.6 ГиБ of RAM Graphics Processor: AMD Radeon RX 6700 XT