Bug 490556

Summary:	Notifications page is mostly empty when instance contains watched posts from a local poster
Product:	[Applications] Tokodon	Reporter:	Christopher Snowhill <kode54>
Component:	general	Assignee:	Unassigned bugs mailing-list <unassigned-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, josh, karl, Michael-Baumgartner
Priority:	NOR
Version:	24.05.2
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/network/tokodon/-/commit/71a37574c2e5350020007a4afc09a4b375652551	Version Fixed In:	24.08.3
Sentry Crash Report:

Description Christopher Snowhill 2024-07-20 12:25:56 UTC

SUMMARY
I have my own Mastodon Glitchsoc instance, and it's failing to display the Notifications All page if it contains a notification of a post by a local admin who I watch all posts by. If their watched post is the most recent, the Notifications page is empty.

STEPS TO REPRODUCE
1. Attach to instance
2. Watch a local user
3. Wait for them to post in your timeline
4. Check Notifications

OBSERVED RESULT
Notifications page is empty. The following message is logged to the terminal each time I switch to the Notifications view:

```
qrc:/qt/qml/org/kde/tokodon/content/ui/NotificationPage.qml:127:9: QML Connections: Detected function "onPostSourceReady" in Connections element. This is probably intended to be a signal handler but no signal of the target matches the name.
```

EXPECTED RESULT
Notifications should populate with all the recent notifications from my instance.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 6.1.3
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.2

Comment 1 Karl Ove Hufthammer 2024-10-02 17:31:17 UTC

I’m not sure the reason is the correct one, as I also get an empty ‘All’ page when I stop following all local users. Anyway, here is what I experience:

Both the ‘All’ and the ‘Posts’ tabs under the ‘Notification’ category are completely empty. The other tabs (‘Mentions’ and ‘Favorites’) work fine, i.e., they show a number of posts.

I have tested this using the latest version from the Git repository.

Comment 2 Joshua Goins 2024-10-19 20:54:27 UTC

Sorry about the wait but this is definitely an issue. Even for me, if I follow *anyone* via notification the page becomes useless.

Comment 3 Joshua Goins 2024-10-19 21:00:46 UTC

Git commit eefc7af272658d90e4889cbc06954e7e10d47b78 by Joshua Goins.
Committed on 19/10/2024 at 21:00.
Pushed by redstrate into branch 'master'.

Fix the notification page breaking when someone posts a status

This is a big oopsie, if you follow anyone via notifications then the
page completely broke due to a missing DelegateChoice.

M  +13   -0    src/content/ui/NotificationPage.qml

https://invent.kde.org/network/tokodon/-/commit/eefc7af272658d90e4889cbc06954e7e10d47b78

Comment 4 Joshua Goins 2024-10-19 21:01:25 UTC

Git commit 71a37574c2e5350020007a4afc09a4b375652551 by Joshua Goins.
Committed on 19/10/2024 at 21:01.
Pushed by redstrate into branch 'release/24.08'.

Fix the notification page breaking when someone posts a status

This is a big oopsie, if you follow anyone via notifications then the
page completely broke due to a missing DelegateChoice.
(cherry picked from commit eefc7af272658d90e4889cbc06954e7e10d47b78)

M  +13   -0    src/content/ui/NotificationPage.qml

https://invent.kde.org/network/tokodon/-/commit/71a37574c2e5350020007a4afc09a4b375652551

Comment 5 Joshua Goins 2024-11-06 01:45:39 UTC

*** Bug 495201 has been marked as a duplicate of this bug. ***