| Summary: | clazy 1.12 does not compile with (the upcoming) clang 19 | ||
|---|---|---|---|
| Product: | [Developer tools] clazy | Reporter: | Peter Klotz <peter.klotz99> |
| Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.lohnau, smartins |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | RedHat Enterprise Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
A patch against clazy 1.12
A patch against clazy 1.13-20240928 |
||
Created attachment 175214 [details]
A patch against clazy 1.12
This patch makes clazy 1.12 work together with clang 19.
Created attachment 175215 [details]
A patch against clazy 1.13-20240928
This patch makes clazy 1.13-20240928 (git revision ef4fa16bf0df98404bfb8df449dfb88e8141840e) work together with clang 19.
This was already fixed and released, closing this bug :) |
clazy 1.12 does not compile with clang 19 because the overridden method InclusionDirective() now has an additional parameter "bool ModuleImported". Tested with a pre-release version of clang 19 (from the LLVM main branch) under Red Hat Enterprise Linux 9. The compiler error message taken from the CMake build: [ 1%] Generating clazy.1 [ 1%] Building CXX object CMakeFiles/ClazyPlugin.dir/cmake_pch.hxx.pch [ 1%] Built target man In file included from <built-in>:1: In file included from clazy/1.12/clazy-Binaries/CMakeFiles/ClazyPlugin.dir/cmake_pch.hxx:5: clazy/1.12/clazy-1.12/src/checkbase.h:99:73: error: non-virtual member function marked 'override' hides virtual member function 99 | clang::SrcMgr::CharacteristicKind FileType) override; | ^ clang19el9/include/clang/Lex/PPCallbacks.h:168:16: note: hidden overloaded virtual function 'clang::PPCallbacks::InclusionDirective' declared here: different number of parameters (11 vs 10) 168 | virtual void InclusionDirective(SourceLocation HashLoc, | ^ 1 error generated. make[2]: *** [CMakeFiles/ClazyPlugin.dir/build.make:77: CMakeFiles/ClazyPlugin.dir/cmake_pch.hxx.pch] Error 1 make[1]: *** [CMakeFiles/Makefile2:117: CMakeFiles/ClazyPlugin.dir/all] Error 2 make: *** [Makefile:166: all] Error 2