Bug 490511

Summary: Rename Show Logout Prompt to something more accurate
Product: [Plasma] plasmashell Reporter: Marc Deop <kde>
Component: Session ManagementAssignee: Nate Graham <nate>
Status: RESOLVED FIXED    
Severity: wishlist CC: natalie_clarius, nate
Priority: NOR Keywords: usability
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Fedora RPMs   
OS: All   
See Also: https://bugs.kde.org/show_bug.cgi?id=489519
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Marc Deop 2024-07-19 16:34:06 UTC 
SUMMARY
Recently a Fedora user reported a change in behaveour for the "Show Logout Prompt". In the past, the preselected action would be to "logout" but this has been changed to "shut down".

STEPS TO REPRODUCE
1. ctrl+alt+del to trigger "Show Logout Prompt"
2. wait...
3. The computer is shutdown

OBSERVED RESULT
While there is nothing wrong with this default behaveour, the _name_ is indeed misleading. We are triggering a "logout" action but we are getting a (by default) "shut down".

EXPECTED RESULT
Could it be possible to rename "Show Logout Prompt" to something more accurate to what we are actually doing?

Our colleague Neal Gompa suggested "Show System Exit Prompt" or perhaps "Show Exit Prompt"

What do you think?

Thank you in advance!

PS: potentially related:
https://bugs.kde.org/show_bug.cgi?id=489519
https://lists.fedoraproject.org/archives/list/kde@lists.fedoraproject.org/thread/BRLZ2CXYSEQCDNXWSKBQBD46LEDAGNXC/
Comment 1 Nate Graham 2024-07-19 19:08:06 UTC 
Git commit 8cb7eebc6f4a64bb0d0e4ffb4757319d59d97841 by Nate Graham.
Committed on 19/07/2024 at 19:04.
Pushed by ngraham into branch 'master'.

Use consistent "logout screen" terminology

In most places we call it the "logout screen", so do the same here,
which is the last place the old "logout prompt" terminology was used.

M  +1    -1    libkworkspace/sessionmanagement.cpp
M  +1    -1    startkde/session-shortcuts/main.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/8cb7eebc6f4a64bb0d0e4ffb4757319d59d97841
Comment 2 Nate Graham 2024-07-19 19:16:32 UTC 
Everything now calls it the "Logout Screen".

If we want to change it to something else, we'll need to change it in the following places:

Shown in UI strings:
- kwin/src/plugins/logout/package/metadata.json
- plasma-workspace/containmentactions/contextmenu/menu.cpp
- plasma-workspace/startkde/session-shortcuts/main.cpp
- plasma-workspace/applets/lock_logout/contents/ui/data.js
- plasma-workspace/applets/lock_logout/contents/ui/ConfigGeneral.qml
- powerdevil/doc/kcm/index.docbook
- powerdevil/kcmodule/common/PowerButtonActionModel.cpp

Mentioned in code comments or debug logging:
- kwin/src/plugins/fade/package/contents/code/main.js
- kwin/src/plugins/fadingpopups/package/contents/code/main.js
- kwin/src/plugins/scale/package/contents/code/main.js
- plasma-workspace/libkworkspace/sessionmanagement.cpp
- plasma-workspace/applets/lock_logout/contents/config/main.xml
- kirigami/CMakeLists.txt


This is enough files in enough different repos that before we proceed, I'd like to have some agreement that 1) we should change it further and 2) what we should change it to.
Comment 3 Nate Graham 2025-02-28 16:54:40 UTC 
No response or further consensus; assuming the current status quo with that change is fine now!