Bug 490201

Summary:	Scrolling has gotten much worse
Product:	[Applications] Tokodon	Reporter:	Joshua Goins <josh>
Component:	general	Assignee:	Joshua Goins <josh>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, josh
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:	24.08
Sentry Crash Report:

Description Joshua Goins 2024-07-12 23:26:44 UTC

I think I know why, I believe it's a combination of some image fallback code and my use of Loaders

Comment 1 Joshua Goins 2024-07-13 00:52:36 UTC

Git commit cbb9c2a70854146f9304d1d2d9d65b476ccd9a6a by Joshua Goins.
Committed on 13/07/2024 at 00:42.
Pushed by redstrate into branch 'master'.

Ensure the privacy warning does not try to wrap when not loaded

This fixes a big scrolling bug, due to it trying to wrap and destroying
the scrolling in the process.

M  +1    -1    src/content/ui/PostDelegate/PostDelegate.qml

https://invent.kde.org/network/tokodon/-/commit/cbb9c2a70854146f9304d1d2d9d65b476ccd9a6a

Comment 2 Joshua Goins 2024-07-13 00:52:44 UTC

Git commit fd8df5f347ac3a7e63b6d038a62204de30c43361 by Joshua Goins.
Committed on 13/07/2024 at 00:52.
Pushed by redstrate into branch 'master'.

Refactor media attachment sizing to "begin" at the top

This fixes a really annoying scrolling lag when showing attachments, and
it's most likely due to layout shenanigans. To avoid this, the
attachments container now determines it's final size and the attachments
within fill the available space - instead of the other way around.

This is not backported to stable intentionally because it will most
likely break something in the meantime.

M  +28   -21   src/content/ui/PostDelegate/AttachmentGrid.qml
M  +0    -35   src/content/ui/PostDelegate/MediaContainer.qml
M  +1    -0    src/content/ui/PostDelegate/PostDelegate.qml
M  +0    -3    src/content/ui/PostDelegate/VideoAttachment.qml

https://invent.kde.org/network/tokodon/-/commit/fd8df5f347ac3a7e63b6d038a62204de30c43361

Comment 3 Joshua Goins 2024-07-13 00:54:49 UTC

Git commit e83a539321d33902c89409b14d7290d0f517f043 by Joshua Goins.
Committed on 13/07/2024 at 00:54.
Pushed by redstrate into branch 'release/24.05'.

Ensure the privacy warning does not try to wrap when not loaded

This fixes a big scrolling bug, due to it trying to wrap and destroying
the scrolling in the process.
(cherry picked from commit cbb9c2a70854146f9304d1d2d9d65b476ccd9a6a)

M  +1    -1    src/content/ui/PostDelegate/PostDelegate.qml

https://invent.kde.org/network/tokodon/-/commit/e83a539321d33902c89409b14d7290d0f517f043

Comment 4 Joshua Goins 2024-07-13 00:55:44 UTC

Some fixes are landed in master & stable. I will continue monitoring the situation but it's greatly improved now, some fixes are not backported to stable due to them being new and I don't want to rock the boat too much.