Bug 490196

Also note that for the pages which include a button on the *top-right* (e.g., the KRunner page), the entire ‘icon + text’ (e.g., icon + ‘Open Settings…’) is clickable. So for consistency, the top-left navigation should behave the same way.

Any changes made here would have to be made to Kirigami, as Welcome Center is using Kirigami's globalToolBar here.

Including the page's title as part of a larger button, in my view, wouldn't make sense as it is not part of the back button or related in any way. It would appear as a label for the button and that'd be confusing.

Layer pages previously featured a centered button beneath the text that acted as a back button, but I decided it was better to go with what Kirigami for greater consistency with other KDE apps and to allow us to expand the content of these pages, which is already partially complete.

N.B. The left arrow key shortcut works here. I think, for layers, it'd be a good idea to allow escape to be pressed, and for everything to also work with mouse back/forward buttons. This is on my TODO list.

(In reply to Karl Ove Hufthammer from comment #1)
> Also note that for the pages which include a button on the *top-right*
> (e.g., the KRunner page), the entire ‘icon + text’ (e.g., icon + ‘Open
> Settings…’) is clickable. So for consistency, the top-left navigation should
> behave the same way.

Furthermore, what we see in the toolbar is a left-aligned title, which is why it is larger than normal ToolButton label text.

(In reply to Oliver Beard from comment #2)
> Including the page's title as part of a larger button, in my view, wouldn't
> make sense as it is not part of the back button or related in any way. It
> would appear as a label for the button and that'd be confusing.

I think the problem is that the title is right next to the button, so it *looks and feels* (at least to me) that it’s attached to the button. So I have (accidentally) tried to click it several times. If it was centred instead, this wouldn’t be an issue.

Created attachment 171622 [details]
Systemsettings screenshot

See also the system settings window, which looks *almost identically* (see attachment), but where the title *is* attached to the back button. Having two things which look almost the same but behaves differently is quite confusing, IMHO.

(In reply to Karl Ove Hufthammer from comment #5)
> Created attachment 171622 [details]
> Systemsettings screenshot
> 
> See also the system settings window, which looks *almost identically* (see
> attachment), but where the title *is* attached to the back button. Having
> two things which look almost the same but behaves differently is quite
> confusing, IMHO.

That's a good point.

As Oliver says, this is a case where we're simply using the standard Kirigami navigation header style, and if we want to change it, we'd have to rethink, well, a lot of things.

It's a bit unfortunate that System Settings' sidebar having a larger back button (it's 100% custom) is habituating people to the idea of large back buttons that include the header text in the clickable area. It works in that context, but it would not work in all Kirigami apps due to the existence of forward buttons in multi-page page stacks.

We could change System Settings to use a smaller clickable area, but that would definitely be a usability regression even as it improved consistency. Sometimes these things are in tension.

I don't see a path forward right now.

I've started an open-ended discussion in Kirigami about it, FWIW: https://invent.kde.org/frameworks/kirigami/-/issues/85