Bug 490181

Summary: Krita 5.2.3 crashes repeatedly when attempting to use audio feature on animations
Product: [Applications] krita Reporter: sophmh9
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: ghevan, halla, penguinflyer2222
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: backtrace

Description sophmh9 2024-07-12 15:06:05 UTC
***
If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

SUMMARY


STEPS TO REPRODUCE
1. create a basic animation in Krita 
2. add an audio file of any of the supported file types


OBSERVED RESULT
Krita closes/crashes without warning. I get a popup on my home screen that says "Krita quit unexpectedly" Using the animation feature without adding audio seems to be working just fine. Only when I try to add an audio file does the program crash. When I look in Krita's logs it also says "KRITA DID NOT CLOSE CORRECTLY"

EXPECTED RESULT
I expect the audio to play normally without crashing or corrupting like it has in the past.

SOFTWARE/OS VERSIONS
macOS: 14.5
Darwin (arm64) release 23.5.0


ADDITIONAL INFORMATION
SESSION: 12 Jul 2024 10:33:34 -0400. Executing /Volumes/krita 1/krita.app/Contents/MacOS/krita

Krita Version: 5.2.3 (git 68d178c), Qt version compiled: 5.15.7, loaded: 5.15.7. Process ID: 6824
-- -- -- -- -- -- -- --
12 Jul 2024 10:33:34 -0400: Style: fusion. Available styles: macintosh, Windows, Fusion
12 Jul 2024 10:33:35 -0400: Database is up to date. Version: 0.0.17, created by Krita 5.1.5, at Thu May 4 10:34:26 2023
12 Jul 2024 10:33:58 -0400: Importing application/x-krita to application/x-krita. Location: /Users/charlie/Desktop/drawlings/movingart/AEshot 7.kra. Real location: /Users/charlie/Desktop/drawlings/movingart/AEshot 7.kra. Batchmode: 0
12 Jul 2024 10:33:58 -0400: Loaded image from application/x-krita. Size: 1756 * 1240 pixels, 4.16667 dpi. Color model: 8-bit integer/channel RGB/Alpha (sRGB-elle-V2-srgbtrc.icc). Layers: 6

KRITA DID NOT CLOSE CORRECTLY
================================================================================

SESSION: 12 Jul 2024 10:34:07 -0400. Executing /Volumes/krita 1/krita.app/Contents/MacOS/krita

Krita Version: 5.2.3 (git 68d178c), Qt version compiled: 5.15.7, loaded: 5.15.7. Process ID: 6831
-- -- -- -- -- -- -- --
12 Jul 2024 10:34:07 -0400: Style: fusion. Available styles: macintosh, Windows, Fusion
12 Jul 2024 10:34:08 -0400: Database is up to date. Version: 0.0.17, created by Krita 5.1.5, at Thu May 4 10:34:26 2023
12 Jul 2024 10:37:25 -0400: Importing application/x-krita to application/x-krita. Location: /Volumes/krita 1/krita.app/Contents/share/krita/templates/animation/.source/Anim-Jp-EN.kra. Real location: /Volumes/krita 1/krita.app/Contents/share/krita/templates/animation/.source/Anim-Jp-EN.kra. Batchmode: 0
12 Jul 2024 10:37:25 -0400: Loaded image from application/x-krita. Size: 1756 * 1240 pixels, 4.16667 dpi. Color model: 8-bit integer/channel RGB/Alpha (sRGB-elle-V2-srgbtrc.icc). Layers: 39

KRITA DID NOT CLOSE CORRECTLY
================================================================================
SESSION: 12 Jul 2024 10:37:49 -0400. Executing /Volumes/krita 1/krita.app/Contents/MacOS/krita

Krita Version: 5.2.3 (git 68d178c), Qt version compiled: 5.15.7, loaded: 5.15.7. Process ID: 6848
-- -- -- -- -- -- -- --
12 Jul 2024 10:37:49 -0400: Style: fusion. Available styles: macintosh, Windows, Fusion
12 Jul 2024 10:37:50 -0400: Database is up to date. Version: 0.0.17, created by Krita 5.1.5, at Thu May 4 10:34:26 2023

---------------------
Comment 1 Freya Lupen 2024-07-12 16:38:06 UTC
Confirmed on 5.2.3 and 5.3.0-prealpha-72ff212 nightly build on macOS. It doesn't happen on my local build (5.3.x-1c2c28d1) for some reason, I'm unsure why (maybe I just have outdated deps).
It doesn't happen with 5.2.3 on Windows or Android (I am unable to test Linux at the moment).

Backtrace:
> Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
> 0   libmlt-7.7.22.0.dylib         	       0x105542aac 0x105510000 + 207532
> 1   libmlt-7.7.22.0.dylib         	       0x105542970 mlt_repository_create + 48
> 2   libmlt-7.7.22.0.dylib         	       0x1055223bc mlt_factory_producer + 188
> 3   libkritaui.19.0.0.dylib       	       0x104852064 0x1042b8000 + 5873764
> 4   libmlt-7.7.dylib              	       0x1075869cc mlt_repository_create + 140
> 5   libmlt-7.7.dylib              	       0x1075663bc mlt_factory_producer + 188
> 6   libmlt++-7.7.22.0.dylib       	       0x105586048 Mlt::Producer::Producer(mlt_profile_s*, char const*, char const*) + 140
> 7   libmlt++-7.7.22.0.dylib       	       0x105586174 Mlt::Producer::Producer(mlt_profile_s*, char const*, char const*) + 52
> 8   libmlt++-7.7.22.0.dylib       	       0x105586130 Mlt::Producer::Producer(Mlt::Profile&, char const*, char const*) + 64
> 9   libkritaui.19.0.0.dylib       	       0x10484ea5c KisPlaybackEngineMLT::setupProducer(boost::optional<QFileInfo>) + 192
> 10  libkritaui.19.0.0.dylib       	       0x10484f784 KisPlaybackEngineMLT::setCanvas(KoCanvasBase*) + 1200
> 11  libkritaui.19.0.0.dylib       	       0x1047def58 KisPart::upgradeToPlaybackEngineMLT(KoCanvasBase*) + 180
> 12  libkritaui.19.0.0.dylib       	       0x104861904 KisCanvasAnimationState::setupAudioTracks() + 540
> 13  QtCore                        	       0x106cc8e3c 0x106ac8000 + 2100796
> 14  libkritaui.19.0.0.dylib       	       0x104789154 KisDocument::setAudioTracks(QVector<QFileInfo>) + 168
> 15  kritaanimationdocker.so       	       0x12eb54454 KisAnimTimelineFramesModel::setAudioChannelFileName(QFileInfo const&) + 108
> 16  kritaanimationdocker.so       	       0x12eb5fd20 KisAnimTimelineFramesView::slotSelectAudioChannelFile() + 236
Comment 2 vanyossi 2024-07-12 21:14:45 UTC
Created attachment 171617 [details]
backtrace

I can reproduce this issue easily on krita 5.2.3, it does not happen on 5.2.2. Could it be related to the fix of bug 488939 ?
However I cannot get it to crash using master (72ff212477e3b3b9)

Attached backtrace
Comment 3 vanyossi 2024-07-26 05:07:44 UTC
Git commit 965cd20df3dd0f1d46dec130158ed3d3de4d83e4 by Ivan Yossi.
Committed on 26/07/2024 at 05:06.
Pushed by ivany into branch 'master'.

run macdeployqt after searching for missing libs

This is implemented as macdeployqt does not deal correctly with
softlinks causing libraries duplication in some rare cases.
Before running qt tool, we copy all libraries krita needs preserving
softlinks. This should not affect qtdeploy as this only makes it
skip the copy phase.

M  +40   -23   packaging/macos/osxdeploy.sh

https://invent.kde.org/graphics/krita/-/commit/965cd20df3dd0f1d46dec130158ed3d3de4d83e4
Comment 4 Dmitry Kazakov 2024-07-27 09:24:07 UTC
Git commit 8adcc4e2a5ff4cd00aa1f3c3af1fab1daf146ac3 by Dmitry Kazakov.
Committed on 27/07/2024 at 09:24.
Pushed by dkazakov into branch 'krita/5.2'.

run macdeployqt after searching for missing libs

This is implemented as macdeployqt does not deal correctly with
softlinks causing libraries duplication in some rare cases.
Before running qt tool, we copy all libraries krita needs preserving
softlinks. This should not affect qtdeploy as this only makes it
skip the copy phase.


(cherry picked from commit 965cd20df3dd0f1d46dec130158ed3d3de4d83e4)

Co-authored-by: Ivan Yossi <ghevan@gmail.com>

M  +40   -23   packaging/macos/osxdeploy.sh

https://invent.kde.org/graphics/krita/-/commit/8adcc4e2a5ff4cd00aa1f3c3af1fab1daf146ac3