Bug 489781

Summary:	Tokodon deletes entire message body when activating the Pop Out feature, with no confirmation
Product:	[Applications] Tokodon	Reporter:	Christopher Snowhill <kode54>
Component:	general	Assignee:	Unassigned bugs <unassigned-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, josh
Priority:	NOR
Version First Reported In:	24.05.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/network/tokodon/-/commit/c405b8022984c2501c8ef27540e07d63e5beb027	Version Fixed In:	24.05.3
Sentry Crash Report:

Description Christopher Snowhill 2024-07-05 10:50:53 UTC

SUMMARY
Tokodon has a Pop Out feature, which I went to invoke so I could look for a username to include in my message. Instead, it deleted my entire message, leaving me with just the username of the person I was replying to.

STEPS TO REPRODUCE
1. Click reply on a message
2. Type in a lengthy message in the main window
3. Click Pop Out

OBSERVED RESULT
Tokodon wipes my entire reply without so much as a consent prompt, and drops me a popup with only the username I was replying to.

EXPECTED RESULT
It should copy the entire message I had already typed into the inline reply form.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
(available in About System)
KDE Plasma Version: 6.1.1
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.2

ADDITIONAL INFORMATION
It did, however, "helpfully" ask me if I wanted to "delete my draft" when I went to close the pop out window containing the empty reply and username.

Comment 1 Joshua Goins 2024-07-05 14:20:38 UTC

Ouch, this is definitely not intentional. Will check up this afternoon, I probably broke something

Comment 2 Joshua Goins 2024-07-06 15:14:09 UTC

Git commit b2311a5f2d2591485beb12a6b0b6279fe4547d3b by Joshua Goins.
Committed on 06/07/2024 at 15:14.
Pushed by redstrate into branch 'master'.

Do not overwrite existing text in composer

This can happen if you "Pop out" the composer while replying to someone,
because it previously overwritten the text with a mention. That should
be fixed now.

M  +7    -4    src/content/ui/StatusComposer/StatusComposer.qml

https://invent.kde.org/network/tokodon/-/commit/b2311a5f2d2591485beb12a6b0b6279fe4547d3b

Comment 3 Joshua Goins 2024-07-06 15:14:25 UTC

Git commit c405b8022984c2501c8ef27540e07d63e5beb027 by Joshua Goins.
Committed on 06/07/2024 at 15:14.
Pushed by redstrate into branch 'release/24.05'.

Do not overwrite existing text in composer

This can happen if you "Pop out" the composer while replying to someone,
because it previously overwritten the text with a mention. That should
be fixed now.
(cherry picked from commit b2311a5f2d2591485beb12a6b0b6279fe4547d3b)

M  +7    -4    src/content/ui/StatusComposer/StatusComposer.qml

https://invent.kde.org/network/tokodon/-/commit/c405b8022984c2501c8ef27540e07d63e5beb027