Summary: | Top Objects like channels(snap), permissions(packagekit), flatpak notifications are not visible | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Soumyadeep Ghosh <soumyadeepghosh2004> |
Component: | discover | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | aleixpol, bugs.kde.org.facelift226, me, nate, radicalite |
Priority: | HI | Keywords: | regression |
Version: | 6.1.0 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/15a277e189cdeedb8feb32428c1375d386f9a9dc | Version Fixed In: | 6.1.4 |
Sentry Crash Report: | |||
Attachments: |
VLC in 6.1.0 plasma discover
VLC in plasma discover without the bindVisibility |
Description
Soumyadeep Ghosh
2024-07-04 16:04:51 UTC
Created attachment 171376 [details]
VLC in plasma discover without the bindVisibility
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/875 Hi Ghosh, your screenshots are featuring VLC from two different sources, one of which ("ubuntu-jammy-universe") could not possibly have topObjects). Are you sure there is a bug? The binding for hasVisibleObjects property only affects the top margin, not the transient visibility of the container. Ah, I see the erroneous `visible: hasVisibleObjects` line has been added in https://invent.kde.org/plasma/discover/-/commit/bca6b4beefcda1fcb80b225c8cd43868cf8321c4#note_985864 Oops, so sorry for the regression! Git commit 101c01494ede10659740827c63dac874bf18f121 by Aleix Pol Gonzalez, on behalf of Aleix Pol. Committed on 19/07/2024 at 00:54. Pushed by apol into branch 'master'. ApplicationPage: Do not use Item.visible to calculate the visibility of the parent Having the parent visible=false will make all children visible:false so it becomes a silly exercise. Instead, use a property made for this that doesn't have other connotations. It kind of feels like we are workarounding a bug in the layout class but this is needs addressing now. M +48 -1 discover/DiscoverDeclarativePlugin.cpp M +17 -10 discover/qml/ApplicationPage.qml M +1 -0 libdiscover/backends/DummyBackend/CMakeLists.txt M +6 -0 libdiscover/backends/DummyBackend/DummyResource.cpp M +1 -0 libdiscover/backends/DummyBackend/DummyResource.h C +3 -4 libdiscover/backends/DummyBackend/qml/DummyTop.qml [from: libdiscover/backends/FlatpakBackend/qml/FlatpakAttention.qml - 063% similarity] A +6 -0 libdiscover/backends/DummyBackend/resources.qrc M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakAttention.qml M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakEolReason.qml M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakOldBeta.qml M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakRemoveData.qml M +1 -2 libdiscover/backends/FlatpakBackend/qml/PermissionsList.qml M +1 -2 libdiscover/backends/PackageKitBackend/qml/DependenciesButton.qml M +1 -0 libdiscover/backends/PackageKitBackend/qml/PackageKitPermissions.qml M +1 -1 libdiscover/backends/SnapBackend/qml/ChannelsButton.qml M +1 -1 libdiscover/backends/SnapBackend/qml/PermissionsButton.qml https://invent.kde.org/plasma/discover/-/commit/101c01494ede10659740827c63dac874bf18f121 Git commit 15a277e189cdeedb8feb32428c1375d386f9a9dc by Aleix Pol Gonzalez. Committed on 19/07/2024 at 01:02. Pushed by apol into branch 'Plasma/6.1'. ApplicationPage: Do not use Item.visible to calculate the visibility of the parent Having the parent visible=false will make all children visible:false so it becomes a silly exercise. Instead, use a property made for this that doesn't have other connotations. It kind of feels like we are workarounding a bug in the layout class but this is needs addressing now. (cherry picked from commit 101c01494ede10659740827c63dac874bf18f121) Co-authored-by: Aleix Pol <aleixpol@kde.org> M +48 -1 discover/DiscoverDeclarativePlugin.cpp M +17 -10 discover/qml/ApplicationPage.qml M +1 -0 libdiscover/backends/DummyBackend/CMakeLists.txt M +6 -0 libdiscover/backends/DummyBackend/DummyResource.cpp M +1 -0 libdiscover/backends/DummyBackend/DummyResource.h C +3 -4 libdiscover/backends/DummyBackend/qml/DummyTop.qml [from: libdiscover/backends/FlatpakBackend/qml/FlatpakAttention.qml - 063% similarity] A +6 -0 libdiscover/backends/DummyBackend/resources.qrc M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakAttention.qml M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakEolReason.qml M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakOldBeta.qml M +1 -1 libdiscover/backends/FlatpakBackend/qml/FlatpakRemoveData.qml M +1 -2 libdiscover/backends/FlatpakBackend/qml/PermissionsList.qml M +1 -2 libdiscover/backends/PackageKitBackend/qml/DependenciesButton.qml M +1 -0 libdiscover/backends/PackageKitBackend/qml/PackageKitPermissions.qml M +1 -1 libdiscover/backends/SnapBackend/qml/ChannelsButton.qml M +1 -1 libdiscover/backends/SnapBackend/qml/PermissionsButton.qml https://invent.kde.org/plasma/discover/-/commit/15a277e189cdeedb8feb32428c1375d386f9a9dc *** Bug 489837 has been marked as a duplicate of this bug. *** |