Bug 489544

Summary: Setting a custom shortcut to a shortcut that already exists for this combination should not show a dialog
Product: [Applications] systemsettings Reporter: cwo <cwo.kde>
Component: kcm_keysAssignee: Plasma Bugs List <plasma-bugs-null>
Status: CONFIRMED ---    
Severity: minor CC: kde, nate
Priority: NOR    
Version First Reported In: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: screenshots clarifying the steps

Description cwo 2024-07-01 11:50:10 UTC 
SUMMARY

If the user assigns a shortcut to an action that is already assigned to that action, a dialog informing the user about the conflict is shown. Both options (Yes/No) lead to the exact same result, no change. The dialog should not be shown.

STEPS TO REPRODUCE
1. System Settings > Shortcuts
2. "Add custom shortcut", press Meta-E 
3. Click "Yes", observe no change to settings was made (Apply button remains deactivated)
4. Repeat 2,
5. Click "No",  observe no change to settings was made (Apply button remains deactivated)

OBSERVED RESULT
The dialog in 3. and 5. has no effect.

EXPECTED RESULT
The dialog should not be shown.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.1.80
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.0

ADDITIONAL INFORMATION

The replication steps use "Add custom shortcut" to set a default shortcut again , but the same holds for changing an existing shortcut such that it is set to itself. 

It does not directly apply to changing an existing custom shortcut into a different shortcut already assigned to that action, whether default or non-default. (e.g. the user has a custom shortcut "Ctrl+Alt+E" assigned to Dolphin, then tries to change the chord for that assignment to Meta+E) The current behavior seems to be: "Yes" removes the extraneous shortcut, " No" keeps the same shortcut assigned twice. My initial reaction would be that having the same shortcut assigned twice is pointless, so it should always remove it. It's also unclear how doubly-assigned shortcuts should behave; if Meta+E is assigned twice, disabling the default shortcut will also disable the custom shortcut. This makes sense, but so would the opposite, it might be best to just prevent it from happening and avoid the problem.
Comment 1 Nate Graham 2024-07-02 18:55:18 UTC 
Where do you see "Add custom shortcut"? Can you attach a screen recording?
Comment 2 cwo 2024-07-02 19:21:06 UTC 
Created attachment 171304 [details]
screenshots clarifying the steps

Sorry, I messed up on the replication steps. Step 1 should read:

1. System Settings > Shortcuts, select Dolphin > Dolphin

I hope it should be clear from there. I'll also attach a couple of screenshots. My testing laptop has faulty RAM, so I have to do it in a vm that's also compiling plasma, and it's terribly slow for a screen recording.
Comment 3 Bug Janitor Service 2024-07-17 03:46:37 UTC 
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Nate Graham 2024-07-22 19:19:06 UTC 
Ah, I get it now. Can confirm.