Bug 489541

Summary:	Error when updating the quote after selecting an unsuitable online quote
Product:	[Applications] kmymoney	Reporter:	Ralf Habacker <ralf.habacker>
Component:	general	Assignee:	KMyMoney Devel Mailing List <kmymoney-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git (master)
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	https://invent.kde.org/office/kmymoney/-/commit/8113cb28a323ae79db50e6f3e5feb0bacdc7a0b8	Version Fixed In:	5.2
Sentry Crash Report:
Attachments:	test file

Description Ralf Habacker 2024-07-01 11:10:10 UTC

Created attachment 171236 [details]
test file

SUMMARY
An existing source can be selected for an entry in the "Update shares and exchange rates" dialog. Sources that are not suitable for the selected type are also displayed. 


STEPS TO REPRODUCE
1. download snapshot for kmymoney from https://cdn.kde.org/ci-builds/office/kmymoney/master/windows/builds
2. unpack archive and start kmymoney
3. open appended test file
4. In the settings dialog select "Online quote sources", press "install button" and install Yahoo.com [Stock]
5. In the menu select "Extra"->"Update shares and exchange rates"
6. choose the entry "EUR -> USD" and set the source to "Yahoo.com [Stock]"
7. Press "Update"

OBSERVED RESULT
A message box appears showing that the update failed.

EXPECTED RESULT
The message should not appear 

SOFTWARE/OS VERSIONS
Windows: 10
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12
Linux: openSUSE Leap 15.5
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Currencies can only be updated from online sources that contain two identifiers, while only one identifier is permitted for share price entries.The selectable sources should be limited accordingly.

Comment 1 Thomas Baumgart 2024-07-13 06:30:53 UTC

Git commit 8113cb28a323ae79db50e6f3e5feb0bacdc7a0b8 by Thomas Baumgart.
Committed on 13/07/2024 at 06:30.
Pushed by tbaumgart into branch 'master'.

Only present quote sources eligible for currency conversion

The edit widget to select the quote source for currency conversion also
allowed to select quote sources for stock price information. When such
an entry was selected, price updates will fail.

This change only adds quote sources to the list which are eligible for
currency conversions.
FIXED-IN: 5.2

M  +8    -1    kmymoney/widgets/onlinesourcedelegate.cpp

https://invent.kde.org/office/kmymoney/-/commit/8113cb28a323ae79db50e6f3e5feb0bacdc7a0b8