| Summary: | [Windows] [Steam] Safe assert in shortcuts matcher | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | theodorateo8 |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | dimula73, fireball124004, xeses16388 |
| Priority: | NOR | ||
| Version: | 5.2.3-beta1 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/72cb6152132394c8de995c1f7706746be408dde7 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Window Krita- Internal Error | ||
*** Bug 489267 has been marked as a duplicate of this bug. *** The bug is twofold: 1) The assert shouldn't happen 2) In the release packages, this safe assert should be hidden from the user Okay, I have made special Krita builds that support testing safe asserts, and I see that safe asserts are **not** present in release builds. It seems like the message is done in some non-release build, like nightly. Anyway, it resolves only a half of the issue, the assert itself is still valid. Hi, theodorateo! Could you share your Krita crashlog file? It should be placed in this location: %localappdata%\kritacrash.log It might help me investigate why this assert triggers at the first place. I have a feeling like this bug is related: https://bugs.kde.org/show_bug.cgi?id=490255 *** Bug 485050 has been marked as a duplicate of this bug. *** Git commit fe42eb944e1827a14aed38c6a4cd968918202200 by Dmitry Kazakov. Committed on 19/07/2024 at 11:18. Pushed by dkazakov into branch 'master'. Add a code for testing asserts 1) Set environment variable: export KRITA_ENABLE_ASSERT_TESTS=1 2) Create an image with a file layer 3) Set file name with any of: * crash_me_with_safe_assert * crash_me_with_normal_assert * crash_me_with_qfatal 4) Press "Open attached file" button (folder icon) CC:kimageshop@kde.org M +13 -0 libs/ui/kis_file_layer.cpp https://invent.kde.org/graphics/krita/-/commit/fe42eb944e1827a14aed38c6a4cd968918202200 Git commit bde35293fa025f692c224a9845b8392cc5acdb60 by Dmitry Kazakov. Committed on 19/07/2024 at 12:05. Pushed by dkazakov into branch 'release/5.2.4'. Fix conflicts between mouse and touch actions requested concurrently When drawing with a stylus on a touch-capable laptop it may happen that a touch event will come in the middle of a stylus stroke. In such a case we should avoid starting any touch action, while a tablet action is still running. This patch basically replaces all the checks for `if (!m_d->runningShortcut)` with `if (!hasRunningShortcut())` which checks for all the types of the actions possible. It basically prohibits running any touch action while table action is running and vice versa. # Conflicts: # libs/ui/input/kis_shortcut_matcher.cpp M +0 -2 libs/ui/input/kis_input_manager.cpp M +47 -73 libs/ui/input/kis_shortcut_matcher.cpp M +0 -3 libs/ui/input/kis_shortcut_matcher.h https://invent.kde.org/graphics/krita/-/commit/bde35293fa025f692c224a9845b8392cc5acdb60 Git commit 8c82627cedcb79680992a746abbe3b9d8f200d40 by Dmitry Kazakov. Committed on 16/07/2024 at 13:46. Pushed by dkazakov into branch 'release/5.2.4'. Add a code for testing asserts 1) Set environment variable: export KRITA_ENABLE_ASSERT_TESTS=1 2) Create an image with a file layer 3) Set file name with any of: * crash_me_with_safe_assert * crash_me_with_normal_assert * crash_me_with_qfatal 4) Press "Open attached file" button (folder icon) M +13 -0 libs/ui/kis_file_layer.cpp https://invent.kde.org/graphics/krita/-/commit/8c82627cedcb79680992a746abbe3b9d8f200d40 Git commit bef988e37709815a80381ca742d89283841ed35a by Dmitry Kazakov. Committed on 19/07/2024 at 12:05. Pushed by dkazakov into branch 'release/5.2.4'. Make sure that the default actions are activated after touch-end M +40 -1 libs/ui/input/kis_shortcut_matcher.cpp https://invent.kde.org/graphics/krita/-/commit/bef988e37709815a80381ca742d89283841ed35a Git commit bad0dd9cd86a9915bf8883f45a68ab5c7ba2d91a by Dmitry Kazakov. Committed on 25/07/2024 at 11:11. Pushed by dkazakov into branch 'master'. Fix conflicts between mouse and touch actions requested concurrently When drawing with a stylus on a touch-capable laptop it may happen that a touch event will come in the middle of a stylus stroke. In such a case we should avoid starting any touch action, while a tablet action is still running. This patch basically replaces all the checks for `if (!m_d->runningShortcut)` with `if (!hasRunningShortcut())` which checks for all the types of the actions possible. It basically prohibits running any touch action while table action is running and vice versa. M +0 -2 libs/ui/input/kis_input_manager.cpp M +47 -73 libs/ui/input/kis_shortcut_matcher.cpp M +0 -3 libs/ui/input/kis_shortcut_matcher.h https://invent.kde.org/graphics/krita/-/commit/bad0dd9cd86a9915bf8883f45a68ab5c7ba2d91a Git commit 1337dc18649ef969c6d4262bba73796cfc51af61 by Dmitry Kazakov. Committed on 25/07/2024 at 11:11. Pushed by dkazakov into branch 'master'. Make sure that the default actions are activated after touch-end M +40 -1 libs/ui/input/kis_shortcut_matcher.cpp https://invent.kde.org/graphics/krita/-/commit/1337dc18649ef969c6d4262bba73796cfc51af61 Git commit 72cb6152132394c8de995c1f7706746be408dde7 by Dmitry Kazakov. Committed on 25/07/2024 at 11:15. Pushed by dkazakov into branch 'krita/5.2'. Fix conflicts between mouse and touch actions requested concurrently When drawing with a stylus on a touch-capable laptop it may happen that a touch event will come in the middle of a stylus stroke. In such a case we should avoid starting any touch action, while a tablet action is still running. This patch basically replaces all the checks for `if (!m_d->runningShortcut)` with `if (!hasRunningShortcut())` which checks for all the types of the actions possible. It basically prohibits running any touch action while table action is running and vice versa. # Conflicts: # libs/ui/input/kis_shortcut_matcher.cpp M +0 -2 libs/ui/input/kis_input_manager.cpp M +47 -73 libs/ui/input/kis_shortcut_matcher.cpp M +0 -3 libs/ui/input/kis_shortcut_matcher.h https://invent.kde.org/graphics/krita/-/commit/72cb6152132394c8de995c1f7706746be408dde7 Git commit a2454daa95e778ccf2c79144cf3d99b8f2dd7263 by Dmitry Kazakov. Committed on 25/07/2024 at 11:15. Pushed by dkazakov into branch 'krita/5.2'. Make sure that the default actions are activated after touch-end M +40 -1 libs/ui/input/kis_shortcut_matcher.cpp https://invent.kde.org/graphics/krita/-/commit/a2454daa95e778ccf2c79144cf3d99b8f2dd7263 |
Created attachment 171228 [details] Window Krita- Internal Error I bought Krita from Steam, and sometimes it crashes without prior warning. I never had the same problem with the free version. I have attached the window that pops up every time, explaining the exact problem.