Bug 489492

Summary: Moving Panel to another screen edge makes its widgets interactive while still in Edit Mode
Product: [Plasma] plasmashell Reporter: Filip <filip.kendes1>
Component: PanelAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nate, niccolo.venerandi
Priority: NOR    
Version: 6.1.1   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 6.1.4
Sentry Crash Report:
Attachments: system tray entries can be opened in Edit Mode

Description Filip 2024-06-30 12:29:38 UTC
Created attachment 171201 [details]
system tray entries can be opened in Edit Mode

SUMMARY
Changing position of the Panel makes Task Manager and System Tray active on the panel, but you can still change the panel settings and use right click to edit panel widgets

STEPS TO REPRODUCE
1. Enter Edit Mode
2. Change Panel position
3. Click on Task Manager and System Tray widgets

OBSERVED RESULT
Panel behaves like the Edit Mode is not active. Widgets/Apps are opened on click

EXPECTED RESULT
Panel is still in the Edit Mode

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.1.1
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.2
Kernel Version: 6.9.7-arch1-1 (64-bit)
Graphics Platform: Wayland
Graphics Processor: NVIDIA GeForce GTX 970/PCIe/SSE2
Comment 1 Nate Graham 2024-07-02 20:09:37 UTC
Can reproduce.
Comment 2 Bug Janitor Service 2024-07-30 11:11:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2410
Comment 3 Bug Janitor Service 2024-07-30 13:36:19 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2412
Comment 4 Marco Martin 2024-07-30 14:24:10 UTC
Git commit 04c6e0f2ce5efc63038defc0477d1d4c2dc2d618 by Marco Martin.
Committed on 30/07/2024 at 13:31.
Pushed by mart into branch 'master'.

Use bindings for anchors

Anchor margins were set by initial properties, which is *not* a
binding, meaning that when the panel form factor changes, the
margins won't be updated.

Use proper bindings instead.
FIXED-IN: 6.1.4

M  +5    -0    containments/panel/contents/ui/ConfigOverlay.qml
M  +1    -5    containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/04c6e0f2ce5efc63038defc0477d1d4c2dc2d618
Comment 5 Marco Martin 2024-07-30 14:24:27 UTC
Git commit dd7531e287e1268ef4801634eda7d8207821d9d2 by Marco Martin.
Committed on 30/07/2024 at 13:35.
Pushed by mart into branch 'Plasma/6.1'.

Use bindings for anchors

Anchor margins were set by initial properties, which is *not* a
binding, meaning that when the panel form factor changes, the
margins won't be updated.

Use proper bindings instead.
FIXED-IN: 6.1.4


(cherry picked from commit 04c6e0f2ce5efc63038defc0477d1d4c2dc2d618)

6204ddf3 Use bindings for anchors

Co-authored-by: Marco Martin <notmart@gmail.com>

M  +5    -0    containments/panel/contents/ui/ConfigOverlay.qml
M  +1    -5    containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/dd7531e287e1268ef4801634eda7d8207821d9d2
Comment 6 ratijas 2024-08-05 22:51:34 UTC
Git commit d9e23184d737a830e2f9061b951b7493bcbd2ebd by ivan tkachenko.
Committed on 05/08/2024 at 21:54.
Pushed by ratijas into branch 'master'.

Use bindings for anchors (this time for real)

Anchor margins were set by initial properties, which is *not* a
binding, meaning that when the panel form factor changes, the
margins won't be updated.

Use proper bindings instead.

Co-Authored-By: Marco Martin <notmart@gmail.com>

M  +4    -4    containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/d9e23184d737a830e2f9061b951b7493bcbd2ebd