| Summary: | Online quote for currencies from yahoo.com does not provide a date/rate pair for the current day | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] alkimia | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | General | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/office/alkimia/-/commit/addab8fa480ee7c36c6d56cb9492927382757157 | Version Fixed In: | 8.2 |
| Sentry Crash Report: | |||
|
Description
Ralf Habacker
2024-06-30 09:42:37 UTC
Seems that the default for the start date is "today" and end date is also "today". Since no entry for this date is found in the returned set the result is OK. Would it make sense to change start date to the last work day if today is a holiday? Or set the start date to today - 1 week (which might be easier to implement) (In reply to Thomas Baumgart from comment #1) > Seems that the default for the start date is "today" and end date is also > "today". Since no entry for this date is found in the returned set the > result is OK. Would it make sense to change start date to the last work day > if today is a holiday? Or set the start date to today - 1 week (which might > be easier to implement) With alkimia's current API, something like this would have to be implemented in every application that uses alkimia. Wouldn't it be better to solve this in alkimia in general ? I imagine this with a setter/getter for the class AlkOnlineQuote, with which you can enable an option: "if you have not found an entry in the interval, supply the last entry". Applications can then decide whether they want this or not. What do you think ? A possibly relevant merge request was started @ https://invent.kde.org/office/alkimia/-/merge_requests/45 The default of this setting could be true when the date range has the same start and end date and it is identical to the current date. Just an idea to keep it simple for the user. (In reply to Thomas Baumgart from comment #4) > The default of this setting could be true when the date range has the same > start and end date and it is identical to the current date. Just an idea to > keep it simple for the user. Good idea, I will change the bool type to an enum { Off, On, Auto } with 'Auto' as default setting. Git commit addab8fa480ee7c36c6d56cb9492927382757157 by Ralf Habacker. Committed on 08/07/2024 at 10:50. Pushed by habacker into branch 'master'. Add support for handling special cases for price and date ranges FIXED-IN:8.2 M +10 -0 src/alkonlinequote.cpp M +45 -0 src/alkonlinequote.h M +20 -3 src/alkonlinequote_p.cpp M +1 -0 src/alkonlinequote_p.h https://invent.kde.org/office/alkimia/-/commit/addab8fa480ee7c36c6d56cb9492927382757157 |