| Summary: | "Scaled" and "Scaled and cropped" placement modes apply poor scaling to high resolution wallpapers in bundle/package form | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Жора Змейкин <katze_942> |
| Component: | Image Wallpaper | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, notmart, qydwhotmail |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/f480c5eb8a8dd7ea30cdfc6930452ef7c46d9212 | Version Fixed In: | 6.1.4 |
| Sentry Crash Report: | |||
| Attachments: |
The wallpaper that I'm installing
This is a cropped screenshot of the desktop. Here, the wallpaper was set via the context menu. This is a cropped screenshot of the desktop. Here the wallpaper was installed via /usr/share/wallpapers/.. Here you can notice a small blur Archive with an image |
||
Created attachment 171027 [details]
This is a cropped screenshot of the desktop. Here, the wallpaper was set via the context menu.
Created attachment 171028 [details]
This is a cropped screenshot of the desktop. Here the wallpaper was installed via /usr/share/wallpapers/.. Here you can notice a small blur
Can you attach a compressed .tar.gz of the entire folder so we can replicate your exact setup better? Created attachment 171114 [details] Archive with an image (In reply to Nate Graham from comment #3) > Can you attach a compressed .tar.gz of the entire folder so we can replicate > your exact setup better? Yes, of course. This archive should be unpacked to "~/.local/share/wallpapers/" or to "/usr/share/wallpapers/" Thanks for attaching it. I can't reproduce the issue with current git master when I apply the wallpaper on my 4k screen with 225% scale. I'll give it another go with a 1080p external screen in a little while. I can reproduce the issue on a 1080p screen at 100% scale when using the "Scaled" or "Scaled and cropped" placement modes. When I apply the same image as a standalone image (not as a bundle inside ~/.local/share/wallpapers/etc etc etc), the issue is not seen. Git commit ada62d202f9f60b8650d50a43818c082031598dc by Marco Martin. Committed on 29/07/2024 at 15:56. Pushed by mart into branch 'master'. Respect centered images size Centered images should be cropped all around if they are bigger than the screen, so we can't limit their sourceSize to the desktop size Use the provider only for svgs: Image always considers images from image providers as scalable (QQuickPixmap::isScalableImageFormat) which changes the internal calculation of the size, having images being rendered on different sizes depending if they are loaded from package or directly Related: bug 490425 M +2 -1 wallpapers/image/imagepackage/contents/ui/mediacomponent/StaticImageComponent.qml M +8 -6 wallpapers/image/plugin/autotests/tst_imagebackend.qml M +2 -2 wallpapers/image/plugin/autotests/tst_imagefrontend.cpp M +2 -1 wallpapers/image/plugin/utils/backgroundtype.h M +5 -1 wallpapers/image/plugin/utils/mediaproxy.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/ada62d202f9f60b8650d50a43818c082031598dc Git commit f480c5eb8a8dd7ea30cdfc6930452ef7c46d9212 by Marco Martin. Committed on 29/07/2024 at 16:31. Pushed by mart into branch 'Plasma/6.1'. Respect centered images size * Respect centered images size Centered images should be cropped all around if they are bigger than the screen, so we can't limit their sourceSize to the desktop size Use the provider only for svgs: Image always considers images from image providers as scalable (QQuickPixmap::isScalableImageFormat) which changes the internal calculation of the size, having images being rendered on different sizes depending if they are loaded from package or directly Related: bug 490425 (cherry picked from commit ada62d202f9f60b8650d50a43818c082031598dc) Co-authored-by: Marco Martin <notmart@gmail.com> M +2 -1 wallpapers/image/imagepackage/contents/ui/mediacomponent/StaticImageComponent.qml M +8 -6 wallpapers/image/plugin/autotests/tst_imagebackend.qml M +2 -2 wallpapers/image/plugin/autotests/tst_imagefrontend.cpp M +2 -1 wallpapers/image/plugin/utils/backgroundtype.h M +5 -1 wallpapers/image/plugin/utils/mediaproxy.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/f480c5eb8a8dd7ea30cdfc6930452ef7c46d9212 |
Created attachment 171026 [details] The wallpaper that I'm installing SUMMARY We created our wallpapers in 3000x3000 resolution and set them as desktop wallpapers through the context menu. They looked clear and everything was fine. Our next step was to prepare the wallpaper as a system wallpaper for all users. We put the wallpaper in "/usr/share/wallpapers/Wallpaper Name/content/images/3000x3000.png", having previously filled in the metadata file.json After preparation, we apply these wallpapers through the system parameters and suddenly notice that the picture quality has deteriorated. The problem was solved by reducing the image resolution to 3000x1687, but it seems to me that this is a bug and this should not be. STEPS TO REPRODUCE 1. Take a wallpaper of 3000x3000 or higher (attached to this message) 2. Put the wallpaper in "/usr/share/wallpapers/Folder/contents/images" or "~/.local/share/wallpapers/Folder/contents/images" (you should also configure metadata.json) 3. Open the system settings and apply the wallpaper. OBSERVED RESULT The wallpaper is slightly blurred, losing quality. EXPECTED RESULT High-quality wallpapers, as when they are installed through the context menu. SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Neon Unstable KDE Plasma Version: 6.1.80 KDE Frameworks Version: 6.4.0 Qt Version: 6.7.0 Graphics Platform: Wayland Screen Resolution: 1920x1080 (the global scale is not used) ADDITIONAL INFORMATION This bug is also relevant in KDE Plasma 5.27.11 and 6.1.1. Just below I will take two screenshots where the difference between wallpapers installed through the context menu and wallpapers installed in another way will be clearly visible