Summary: | Bad hypothesis taken on SRU fetcher | ||
---|---|---|---|
Product: | [Applications] tellico | Reporter: | glorfindel_ildarion |
Component: | general | Assignee: | Robby Stephenson <robby> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 3.4.4 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/office/tellico/-/commit/2a642fd4a0c616eeb5a65a60cb0efdd68108343a | Version Fixed In: | 3.5.5 |
Sentry Crash Report: |
Description
glorfindel_ildarion
2024-06-21 21:28:24 UTC
Git commit b9145dd9528b0c84aeab4b4e2844fa661ee3be57 by Robby Stephenson. Committed on 23/06/2024 at 22:18. Pushed by rstephenson into branch '3.5'. Allow user-entered data to override the SRU index for given searches By adding a custom query such as x-tellico-isbn, the user can override the index of the SRU query. Additionally, switch the query operator to use 'adj' instead of '=' for versions other than 1.1. Also allow for x-tellico-title to override the title index. FIXED-IN: 3.5.5 M +58 -17 src/fetch/srufetcher.cpp M +1 -0 src/fetch/srufetcher.h M +52 -0 src/tests/srufetchertest.cpp M +2 -0 src/tests/srufetchertest.h M +3 -0 xslt/mods2tellico.xsl https://invent.kde.org/office/tellico/-/commit/b9145dd9528b0c84aeab4b4e2844fa661ee3be57 Thanks for the detailed bug report and additional information. It made things much easier to implement. For your BnF search and this fix, add x-tellico-isbn,bib.isbn to the custom query (as you suggested) and make sure to enter the format as marcxchange Git commit 2a642fd4a0c616eeb5a65a60cb0efdd68108343a by Robby Stephenson. Committed on 23/06/2024 at 22:00. Pushed by rstephenson into branch 'master'. Allow user-entered data to override the SRU index for given searches By adding a custom query such as x-tellico-isbn, the user can override the index of the SRU query. Additionally, switch the query operator to use 'adj' instead of '=' for versions other than 1.1. Also allow for x-tellico-title to override the title index. FIXED-IN: 3.5.5 M +58 -17 src/fetch/srufetcher.cpp M +1 -0 src/fetch/srufetcher.h M +52 -0 src/tests/srufetchertest.cpp M +2 -0 src/tests/srufetchertest.h M +3 -0 xslt/mods2tellico.xsl https://invent.kde.org/office/tellico/-/commit/2a642fd4a0c616eeb5a65a60cb0efdd68108343a |