| Summary: | Text inside pie chart overflows to next line | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Miroslav Jarý <mira.jary> |
| Component: | System Monitor widgets | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 6ot3tjpxk, ahiemstra, nate, notmart, pavel23dob |
| Priority: | NOR | Keywords: | regression |
| Version: | 6.2.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=492299 | ||
| Latest Commit: | https://invent.kde.org/plasma/libksysguard/-/commit/53c89c046014e2deaf4b21a3dae9611a53d35dbc | Version Fixed In: | 6.2.0 |
| Sentry Crash Report: | |||
| Attachments: |
Overflow screenshot (on 42px panel)
Widget on 42px panel height (Plasma 6.2) Widget on 44px panel height (Plasma 6.2) Widget on 48px panel height (Plasma 6.2) |
||
|
Description
Miroslav Jarý
2024-06-21 05:39:26 UTC
Looks like this is an intentional fix for bug 453797, but that commit does seem to be causing the text to wrap (or disappear completely) earlier than it really should. Yeah, it seems like a regression from the change to allow it to be multi-line. This is fine when the pie chart is large, but not when it's small. A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/360 There is only so much we can do here, since the area that is available is quite limited. Ultimately with the options I had I found wrapping the text to be the best solution. The above MR relaxes the constraints a little bit, which means wrapping happens a bit later, at the tradeoff of text begin rendered on top of the chart, with potential contrast issues. Git commit 53c89c046014e2deaf4b21a3dae9611a53d35dbc by Arjen Hiemstra. Committed on 03/07/2024 at 15:07. Pushed by ahiemstra into branch 'master'. faces/pie: Allow center text to overlap the chart at small sizes We now constrain the text so it never goes outside the central pie area, but for small sizes this would cause things to wrap too early for people's tastes. This change allows the text to overflow onto the pie chart while still being constrained to the total applet size. When this happens we render the text with an outline to improve contrast. outline M +16 -2 faces/facepackages/piechart/contents/ui/UsedTotalDisplay.qml https://invent.kde.org/plasma/libksysguard/-/commit/53c89c046014e2deaf4b21a3dae9611a53d35dbc It seems that this issue has resurfaced after updating to plasma 6.2. See attached pictures - on 42px height the text is highlighted as you've said (although not sure if the effect isn't overdone). On 44 - 48px text is cropped. I think that the rounding which is done on smaller sizes is a neat solution and I would prefer it over the chart overflowing. Created attachment 174626 [details]
Widget on 42px panel height (Plasma 6.2)
Created attachment 174627 [details]
Widget on 44px panel height (Plasma 6.2)
Created attachment 174628 [details]
Widget on 48px panel height (Plasma 6.2)
This is a different issue though. The one here is about text wrapping, not being clipped. Can you open a new bug report about it? Thanks! |