Bug 488850

Summary: Desktop Effects kcm is suggested when searching for "Shake Cursor" in System Settings
Product: [Applications] systemsettings Reporter: cwo <cwo.kde>
Component: kcm_kwineffectsAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: fanzhuyifan, filip.kendes1, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 6.1.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kwin/-/commit/9e57469c2fd60993ecd1c40d479416201c2183a3 Version Fixed In:
Sentry Crash Report:

Description cwo 2024-06-21 00:16:53 UTC 
The X-KDE-Keywords line in src/kcms/effects/kcm_kwin_effects.json contains many keywords related to the Shake Cursor functionality, meaning that it will show up for search terms that users looking to configure this feature will likely make.

Shake Cursor as a desktop effect, however, is an internal effect that will not show up by default, and to the best of my knowledge this is not the encouraged way of disabling the Shake Cursor functionality, and further configuration options are not available there (only in the intended configuration kcm, accessibility).

Less-enfranchised users who select this kcm from the search results will wonder why this was included when it does not seem to contain anything related to shaking cursors, and highly enfranchised users may wonder why disabling this functionality was hidden behind an internal effect. 

It's also unusual generally for hidden effects to be listed in the keywords - I did not check all of them, but of the ones I did check, none were keywords. 

STEPS TO REPRODUCE
1. Open System Settings
2. Search for "Shake"


OBSERVED RESULT

Desktop Effects is in the search results

EXPECTED RESULT

Desktop Effects is not in the search results

SOFTWARE/OS VERSIONS

Current Neon

KDE Plasma Version: 6.1.80
Comment 1 fanzhuyifan 2024-06-21 05:02:26 UTC 
Would you be interested in submitting a MR for this? See https://community.kde.org/Get_Involved/development for more instructions.

Thanks!
Comment 2 cwo 2024-06-21 06:56:27 UTC 
Sure, the change is trivial. It might take me a bit to find the time to correctly set up everything though.
Comment 3 Filip 2024-06-25 09:46:05 UTC 
(In reply to cwo from comment #2)
> Sure, the change is trivial. It might take me a bit to find the time to correctly set up everything though.

Hey, are you working on this? I was about to fix a similar issue so I thought about fixing this one too, but don't want to take it if you're  working on it.
Comment 4 cwo 2024-06-25 10:19:51 UTC 
I started setting up to be able to do it (get the accounts in order, local setup, etc) but I'm not done and haven't started on the actual work yet. Feel free to take this over if it's convenient for you, I'll find something else to do soon enough.
Comment 5 Filip 2024-06-25 10:36:29 UTC 
Nah. You can do it. Have fun.
Comment 6 Vlad Zahorodnii 2024-06-26 06:14:48 UTC 
Git commit 9e57469c2fd60993ecd1c40d479416201c2183a3 by Vlad Zahorodnii.
Committed on 26/06/2024 at 06:02.
Pushed by vladz into branch 'master'.

kcms/effects: Remove shake cursor keywords

It's confusing when the Desktop Effects shows up in the search results
while looking for "shake cursor".

M  +1    -1    src/kcms/effects/kcm_kwin_effects.json

https://invent.kde.org/plasma/kwin/-/commit/9e57469c2fd60993ecd1c40d479416201c2183a3