Bug 488789

Summary:	"Add widget ..." button on an empty floating top panel is vertically off-center
Product:	[Plasma] plasmashell	Reporter:	cwo <cwo.kde>
Component:	Panel	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, niccolo.venerandi
Priority:	NOR
Version First Reported In:	6.1.0
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/-/commit/c264cd884ee4c1a0d3ac672aabeedb10463b86a7	Version Fixed/Implemented In:	6.1.2
Sentry Crash Report:
Attachments:	Position of the Add Widget button for non-floating, floating, and defloated empty panel

Description cwo 2024-06-20 13:34:21 UTC

SUMMARY

An empty panel has a flat button guiding the user to add widgets. On a non-floating panel, everything is fine. On a floating panel, however, the button is quite off-center, and on a defloated panel it is even worse, with text being cut off. It looks like the position adjustment for floating is applied twice. 

This is completely reproducible on a fresh profile here.

STEPS TO REPRODUCE
1. Right click the desktop, Enter Edit Mode, Add Panel.
2. If the newly created panel is not at the top, move it to the top using Panel Configuration mode.
3. Exit Edit mode.

OBSERVED RESULT

The flat "Add Widgets..." button is positioned incorrectly, see the attachment

EXPECTED RESULT

The button is vertically centered, and completely within the panel containment.

SOFTWARE/OS VERSIONS

Current Neon Developer

KDE Plasma Version: 6.1.80
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.0

ADDITIONAL INFORMATION

Comment 1 cwo 2024-06-20 13:35:36 UTC

Created attachment 170676 [details]
Position of the Add Widget button for non-floating, floating, and defloated empty panel

Comment 2 Bug Janitor Service 2024-06-26 15:15:05 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2344

Comment 3 Niccolò Venerandi 2024-06-26 15:29:22 UTC

Git commit eb6d55a718d745dd1f64a3834b44c4e54904815f by Niccolò Venerandi, on behalf of Niccolo Venerandi.
Committed on 26/06/2024 at 15:28.
Pushed by niccolove into branch 'master'.

Always center "Add Widgets" button on empty panels

M  +1    -9    containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/eb6d55a718d745dd1f64a3834b44c4e54904815f

Comment 4 Niccolò Venerandi 2024-06-26 15:29:44 UTC

Git commit c264cd884ee4c1a0d3ac672aabeedb10463b86a7 by Niccolò Venerandi.
Committed on 26/06/2024 at 15:29.
Pushed by niccolove into branch 'Plasma/6.1'.

Always center "Add Widgets" button on empty panels


(cherry picked from commit eb6d55a718d745dd1f64a3834b44c4e54904815f)

Co-authored-by: Niccolo Venerandi <niccolo@venerandi.com>

M  +1    -9    containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/c264cd884ee4c1a0d3ac672aabeedb10463b86a7