Bug 488771

Summary: Move UI for colorblindness filter effect to accessibility KCM, and mark it as an internal effect so it doesn't appear in the effects KCM
Product: [Plasma] kwin Reporter: Nate Graham <nate>
Component: effects-variousAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: hedim74889, xaver.hugl
Priority: NOR Keywords: usability
Version: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 6.2.0
Sentry Crash Report:

Description Nate Graham 2024-06-20 04:49:00 UTC
It's awfully weird for this to live in a KCM that's in the "Window Management" category. It doesn't have anything to do with window management!
Comment 1 Zamundaaa 2024-06-20 23:31:27 UTC
I agree, this really doesn't belong in the effects.
Before we can do this though, we need to fix the effect so that it works with all display settings. If you have an ICC profile or HDR enabled, it messes up the colors a lot.
Comment 2 Nate Graham 2024-08-28 15:51:17 UTC
Git commit fc176845b25759f8f80ce11e1741bc925cd2b6f8 by Nate Graham, on behalf of Thomas Duckworth.
Committed on 28/08/2024 at 15:51.
Pushed by ngraham into branch 'master'.

kcms/access: Move the Color Blindness Correction settings page here

This makes far more sense than having it in Desktop Effects, which is
essentially an implementation detail which should be moved away from,
especially for accessibility components.

This also slightly reorganizes the page to make more sense within the
context of the Accessibility KCM. It also adds some slider labels and
sets a minimum value higher than 0, because for some reason the KCM
goes back to full intensity when set to 0, but not in the Desktop
Effect configuration. Being able to set it to 0 is redundant anyway
now that there's an enablement checkbox.

See also https://invent.kde.org/plasma/kwin/-/merge_requests/6317
which sets the corresponding Desktop Effect as internal.
FIXED-IN: 6.2.0

M  +4    -2    kcms/access/CMakeLists.txt
M  +1    -1    kcms/access/kcm_access.json
M  +39   -0    kcms/access/kcmaccess.cpp
M  +6    -0    kcms/access/kcmaccess.h
A  +25   -0    kcms/access/kcmaccessibilitycolorblindnesscorrection.kcfg
A  +9    -0    kcms/access/kcmaccessibilitycolorblindnesscorrection.kcfgc
A  +140  -0    kcms/access/ui/ColorblindnessCorrection.qml     [License: GPL(v2.0+)]
M  +6    -0    kcms/access/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/fc176845b25759f8f80ce11e1741bc925cd2b6f8
Comment 3 Vlad Zahorodnii 2024-08-28 23:56:28 UTC
Git commit 3b918b4409527c1a03763c7df578d17dce89c053 by Vlad Zahorodnii, on behalf of Thomas Duckworth.
Committed on 28/08/2024 at 23:56.
Pushed by vladz into branch 'master'.

plugins/colorblindnesscorrection: mark as internal and remove configuration UI

Depends on https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2472
as it's being moved to the Accessibility KCM for greater… accessibility!

M  +1    -1    src/kcms/effects/kcm_kwin_effects.json
M  +9    -37   src/plugins/colorblindnesscorrection/CMakeLists.txt
M  +1    -1    src/plugins/colorblindnesscorrection/colorblindnesscorrection.cpp
M  +2    -2    src/plugins/colorblindnesscorrection/colorblindnesscorrection.qrc
D  +0    -59   src/plugins/colorblindnesscorrection/colorblindnesscorrection_config.cpp
D  +0    -35   src/plugins/colorblindnesscorrection/colorblindnesscorrection_config.h
D  +0    -10   src/plugins/colorblindnesscorrection/colorblindnesscorrection_settings.kcfgc.in
R  +1    -1    src/plugins/colorblindnesscorrection/colorblindnesscorrectionconfig.kcfg [from: src/plugins/colorblindnesscorrection/colorblindnesscorrection_settings.kcfg.in - 095% similarity]
A  +7    -0    src/plugins/colorblindnesscorrection/colorblindnesscorrectionconfig.kcfgc
D  +0    -45   src/plugins/colorblindnesscorrection/kwin_colorblindnesscorrection_config.json
D  +0    -2    src/plugins/colorblindnesscorrection/kwin_colorblindnesscorrection_config.json.license
M  +3    -1    src/plugins/colorblindnesscorrection/metadata.json
R  +0    -0    src/plugins/colorblindnesscorrection/shaders/colorblindnesscorrection.frag [from: src/plugins/colorblindnesscorrection/shaders/colorblindesscorrection.frag - 100% similarity]
R  +0    -0    src/plugins/colorblindnesscorrection/shaders/colorblindnesscorrection_core.frag [from: src/plugins/colorblindnesscorrection/shaders/colorblindesscorrection_core.frag - 100% similarity]
D  +0    -94   src/plugins/colorblindnesscorrection/ui/main.qml

https://invent.kde.org/plasma/kwin/-/commit/3b918b4409527c1a03763c7df578d17dce89c053
Comment 4 Akseli Lahtinen 2024-09-17 13:45:14 UTC
*** Bug 482110 has been marked as a duplicate of this bug. ***