Bug 488632

Summary:	Misleading Button Title "Edit" when editing a post
Product:	[Applications] Tokodon	Reporter:	Nicco Kunzmann <niccokunzmann>
Component:	general	Assignee:	Unassigned bugs mailing-list <unassigned-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, josh
Priority:	NOR
Version:	24.02.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/network/tokodon/-/commit/1cbd85f7496fbf58c2b04805fe1aa614cf23f345	Version Fixed In:	24.08
Sentry Crash Report:

Description Nicco Kunzmann 2024-06-17 18:40:37 UTC

SUMMARY

When I edit a post, I would like the button to say "Save edited Post"

STEPS TO REPRODUCE
1. Post a post
2. Edit the post
3. See the button

OBSERVED RESULT

Button Says "Edit"

EXPECTED RESULT

Button says "Save edited Post"

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Joshua Goins 2024-06-18 15:48:23 UTC

What's misleading about it? Does it maybe not come across clearly?

The problem with having text so long is that it affects translations (this is already affecting the German translation for example), and I'm not super pleased with a button that's more than 2 words

Comment 2 Nicco Kunzmann 2024-06-19 08:31:02 UTC

For shortness, "edit" could be replaced by "Save" or "Save Modification"
- I would understand that as the button then denotes an action that is
commonly used in other applications.

Comment 3 Joshua Goins 2024-06-19 20:26:05 UTC

I like the idea of saying "save" in the text, I'll look into changing it

Comment 4 Bug Janitor Service 2024-06-19 20:30:03 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/tokodon/-/merge_requests/509

Comment 5 Joshua Goins 2024-06-19 20:43:30 UTC

Git commit 1cbd85f7496fbf58c2b04805fe1aa614cf23f345 by Joshua Goins.
Committed on 19/06/2024 at 20:29.
Pushed by redstrate into branch 'master'.

Specify that you're "saving" an edit in the composer

This button didn't clearly reflect what you're doing when you edit a
post. You're *currently* editing, so like a "Post" action when you're
done typing it should "Save" (your edit) instead. The icon is changed
to accommodate as well.

M  +2    -2    src/content/ui/StatusComposer/StatusComposer.qml

https://invent.kde.org/network/tokodon/-/commit/1cbd85f7496fbf58c2b04805fe1aa614cf23f345