Bug 488631

Summary: Cannot remove content warning
Product: [Applications] Tokodon Reporter: Nicco Kunzmann <niccokunzmann>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: carl, josh
Priority: NOR    
Version: 24.02.2   
Target Milestone: ---   
Platform: Flatpak   
OS: Linux   
Latest Commit: https://invent.kde.org/network/tokodon/-/commit/c939d15790ef12a58efa2996ecc9b006f231a876 Version Fixed In: 24.05.2
Sentry Crash Report:

Description Nicco Kunzmann 2024-06-17 18:37:26 UTC 
SUMMARY

When I edit a post, I cannot remove the content warning I gave it.

STEPS TO REPRODUCE
1. Create a post and add a content warning to it.
2. Post the Post
3. Edit the post again

OBSERVED RESULT

Content warning is not clicked.
The content warning text I entered is not there.

EXPECTED RESULT

I would like to content warning to be clicked and be able to disable it.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2024-06-19 20:41:27 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/tokodon/-/merge_requests/510
Comment 2 Joshua Goins 2024-06-19 20:49:53 UTC 
Git commit 323a1ff2c6c40ce2203e95414a0ba5a102a917d8 by Joshua Goins.
Committed on 19/06/2024 at 20:49.
Pushed by redstrate into branch 'master'.

Actually propagate the spoiler text to the composer when editing a post

An oversight by me, it should be refreshing the data just like when
popping out the composer.

M  +2    -1    src/content/ui/ExplorePage.qml
M  +2    -1    src/content/ui/NotificationPage.qml
M  +2    -1    src/content/ui/TimelinePage.qml

https://invent.kde.org/network/tokodon/-/commit/323a1ff2c6c40ce2203e95414a0ba5a102a917d8
Comment 3 Joshua Goins 2024-06-19 20:50:01 UTC 
Git commit aff4bd3ed06c290a8d7d3e116647918bb94e4be0 by Joshua Goins.
Committed on 19/06/2024 at 20:49.
Pushed by redstrate into branch 'master'.

Let users be able to clear content warning

Now whether the spoiler text is actually passed to the post
editor backend depends on if the CW box is checked. Previously it would
still send it off to the server, because the C++ code has no idea what
the UI state is.

M  +14   -1    src/content/ui/StatusComposer/StatusComposer.qml

https://invent.kde.org/network/tokodon/-/commit/aff4bd3ed06c290a8d7d3e116647918bb94e4be0
Comment 4 Joshua Goins 2024-06-19 20:52:17 UTC 
Git commit 0296d5dac9f0c534b648471a7f983e6c122b2cc1 by Joshua Goins.
Committed on 19/06/2024 at 20:50.
Pushed by redstrate into branch 'release/24.05'.

Actually propagate the spoiler text to the composer when editing a post

An oversight by me, it should be refreshing the data just like when
popping out the composer.
(cherry picked from commit 323a1ff2c6c40ce2203e95414a0ba5a102a917d8)

M  +2    -1    src/content/ui/ExplorePage.qml
M  +2    -1    src/content/ui/NotificationPage.qml
M  +2    -1    src/content/ui/TimelinePage.qml

https://invent.kde.org/network/tokodon/-/commit/0296d5dac9f0c534b648471a7f983e6c122b2cc1
Comment 5 Joshua Goins 2024-06-19 20:52:25 UTC 
Git commit c939d15790ef12a58efa2996ecc9b006f231a876 by Joshua Goins.
Committed on 19/06/2024 at 20:50.
Pushed by redstrate into branch 'release/24.05'.

Let users be able to clear content warning

Now whether the spoiler text is actually passed to the post
editor backend depends on if the CW box is checked. Previously it would
still send it off to the server, because the C++ code has no idea what
the UI state is.
(cherry picked from commit aff4bd3ed06c290a8d7d3e116647918bb94e4be0)

M  +14   -1    src/content/ui/StatusComposer/StatusComposer.qml

https://invent.kde.org/network/tokodon/-/commit/c939d15790ef12a58efa2996ecc9b006f231a876