Bug 488452

Summary: The "Edit" toolbar is hidden by default, which is causing confusion
Product: [Applications] krita Reporter: Tyson Tan <tysontanx>
Component: DockersAssignee: Emmet O'Neill <emmetoneill.pdx>
Status: RESOLVED FIXED    
Severity: normal CC: emmetoneill.pdx, halla, hernane.iziljr
Priority: NOR Keywords: regression
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: https://invent.kde.org/graphics/krita/-/commit/cb34bd4f66151a5ddafde548d282f444755965e9 Version Fixed In:
Sentry Crash Report:

Description Tyson Tan 2024-06-13 13:56:48 UTC 
Krita has 3 toolbars. They are "File", "Edit", "Brushes and Stuff".

The "Edit" toolbar is hidden by default. It holds two very frequently used actions: Undo & Redo.

Because the toggling of toolbar visibility is hidden away in an obscure place, people often got confused by why the Undo/Redo buttons cannot be shown, even though "they have already been added to a toolbar". 

I, for one, got confused by this issue before. And today, a moderator of our local community also got confused, and they reported this to me as a "suspected bug". We both ran into this under the Android version, because we really needed those buttons on a touchscreen. Given how experienced we both were, and yet still fell for it, I think it's safe to assume more people would have been confused by this, as well.

I suggest we show the "Edit" toolbar by default, and we should move it next to the "File" toolbar. I think that is where it is supposed to be.
Comment 1 Halla Rempt 2024-06-13 14:00:10 UTC 
That's a regression, it used to be visible by default not that long ago.
Comment 2 Emmet O'Neill 2024-10-24 03:46:57 UTC 
Git commit cb34bd4f66151a5ddafde548d282f444755965e9 by Emmet O'Neill.
Committed on 24/10/2024 at 03:46.
Pushed by emmetoneill into branch 'master'.

GUI: Restored undo/redo mainToolBar actions.

It looks like these actions were unsucessfully moved
from "mainToolBar" to "editToolBar" at some point.
This was causing the undo/redo buttons to not appear
on the main toolbar anymore.

This took a bit longer to debug than I'd have hoped
due to the difficulty with bisecting and unfamiliarity
with some of the xmlgui stuff.

M  +5    -2    krita/krita5.xmlgui

https://invent.kde.org/graphics/krita/-/commit/cb34bd4f66151a5ddafde548d282f444755965e9
Comment 3 Tyson Tan 2024-10-24 08:13:52 UTC 
Thank you, Emmet!
Comment 4 Halla Rempt 2024-10-24 09:20:19 UTC 
*** Bug 485864 has been marked as a duplicate of this bug. ***