Bug 488376

Summary:	Okular not displaying some de facto standard annotation icons
Product:	[Applications] okular	Reporter:	nilskemail+kde
Component:	PDF backend	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	aacid, kde
Priority:	NOR
Version First Reported In:	24.05.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	A screenshot of the de-facto standard annotation icons which are not supported

Description nilskemail+kde 2024-06-11 18:26:30 UTC

Created attachment 170385 [details]
A screenshot of the de-facto standard annotation icons which are not supported

SUMMARY
Okular does not display the Check, Star, RightArrow, RightPointer, UpArrow, UpLeftArrow, and CrossHairs icons

STEPS TO REPRODUCE
1. Open http://mirrors.ctan.org/macros/latex/contrib/pdfcomment/doc/pdfcomment.pdf
2. Scroll to section 1.2.4

OBSERVED RESULT
Of the non-mandatory icons, only Circle and Cross are shown (though the others are clickable - so they are simply invisible).

EXPECTED RESULT
The other icons should also be supported, or at least a fallback icon should be displayed.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
- Chromium simply displays them with the Comment icon.
- PDF.js displays them as "[Star Annotation]" etc.

Comment 1 Sune Vuorela 2024-06-12 07:23:55 UTC

Hi

This is a bug in Poppler, and can and should be fixed there.

https://gitlab.freedesktop.org/poppler/poppler/-/blob/master/poppler/Annot.cc#L2690 is where extensions needs to happen and matching icons in whatever language this is https://gitlab.freedesktop.org/poppler/poppler/-/blob/master/poppler/Annot.cc#L2636 needs to be created.

Comment 2 Albert Astals Cid 2024-06-12 15:31:37 UTC

As Sune says nothing to change in Okular.

Comment 3 nilskemail+kde 2024-06-12 16:42:22 UTC

Reported upstream as https://gitlab.freedesktop.org/poppler/poppler/-/issues/1492