Bug 488273

Summary:	Correct stdout errors generated when user selects Settings -> Configure Knights.
Product:	[Applications] knights	Reporter:	Mark Capella <markjamescapella>
Component:	general	Assignee:	Mark Capella <markjamescapella>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aacid, kde-games-bugs-null
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/games/knights/-/commit/1a134169f0791afad470e84395336dc1b1a321e9	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot of the stdout errors. Patch lookahead

Description Mark Capella 2024-06-09 21:54:48 UTC

Created attachment 170303 [details]
Screenshot of the stdout errors.

SUMMARY
Errors in stdout point to bug caused by dissimilar consumers of common method addClicked()
in module enginesettings.cpp

STEPS TO REPRODUCE
1. Start knights from a terminal.
2. Select "Settings" from the menubar.
3.  Select "Configure Knights..." from the drop down.

OBSERVED RESULT
Error "edit: editing failed" appears three times in stdout.

EXPECTED RESULT
Clean stdout / code.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Mark Capella 2024-06-09 22:02:04 UTC

Created attachment 170305 [details]
Patch lookahead

Comment 2 Albert Astals Cid 2024-06-12 20:19:27 UTC

Please use https://invent.kde.org/games/knights/ to send patches :)

Comment 3 Albert Astals Cid 2024-06-17 21:56:43 UTC

Git commit 1a134169f0791afad470e84395336dc1b1a321e9 by Albert Astals Cid, on behalf of Mark Capella.
Committed on 17/06/2024 at 21:56.
Pushed by aacid into branch 'master'.

Fix warning when opening the Settings dialog

M  +15   -5    src/enginesettings.cpp
M  +3    -0    src/enginesettings.h

https://invent.kde.org/games/knights/-/commit/1a134169f0791afad470e84395336dc1b1a321e9