Bug 488269

Summary:	Layouts: Editing shortcut does not change the "needs save" state, i.e. does not refresh the Apply button
Product:	[Applications] systemsettings	Reporter:	ratijas <me>
Component:	kcm_keyboard	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	CONFIRMED ---
Severity:	normal	CC:	bizyaev, butirsky, evgeniyharchenko.dev, natalie_clarius, nate
Priority:	NOR
Version First Reported In:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description ratijas 2024-06-09 21:12:32 UTC

SUMMARY
The model changes such as changing the Shortcut of a layout are not wired up to call KCMKeyboard::settingsChanged() in order to refresh the KCMKeyboard::isSaveNeeded() state. This means you can't apply a new shortcut unless you also change some other setting as well.

STEPS TO REPRODUCE
1. Open Keyboard KCM, navigate to the Layouts tab.
2. Check the Configure Layouts check box.
3. Add some layouts to the table.
4. Apply any pending changes now, make sure that the Apply button is disabled.
5. Double click any layout's Shortcut column.
6. Input some key sequence, and click the Reassign shortcut button (the one with a check mark, on the right of the key sequence input button).

OBSERVED RESULT
The Apply button is still disabled, despite having pending changes to save. If you change any other option such as Switching Policy, the Apply button would become enabled again; then you could click it and change Switching Policy back and click again so that only changes to the shortcuts persist.

EXPECTED RESULT
Changes to the shortcuts should update the Apply button.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: git-master
KDE Frameworks Version: git-master
Qt Version: 6.7.1
Kernel Version: 6.9.3-arch1-1 (64-bit)
Graphics Platform: X11

Comment 1 ratijas 2024-06-09 22:22:36 UTC

More info:

It appears that the shortcuts are being applied to immediately when user confirms with Reassign shortcut button, without the need to click the Apply button. I guess this is just a UI inconsistency then?

Comment 2 Nate Graham 2024-06-10 18:15:56 UTC

Can confirm.