| Summary: | Fails to update due to PK enum changes (in git main) | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Sid <sidtosh4> |
| Component: | PackageKit | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | grave | CC: | aleixpol, matthias, nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://github.com/PackageKit/PackageKit/issues/769 | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/8204a2fd9d0f1b848155bd91670933cb6994c0ae | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Sid
2024-06-08 17:18:46 UTC
The below patch would be handy to reproduce this issue as KDE Discover tries to download changelog of 2K+ packages which takes a huge amount of time.
--- a/backends/apt/apt-job.cpp
+++ b/backends/apt/apt-job.cpp
@@ -894,13 +894,7 @@ void AptJob::stageUpdateDetail(GPtrArray *updateArray, const pkgCache::VerIterat
// fetch the changelog
pk_backend_job_set_status(m_job, PK_STATUS_ENUM_DOWNLOAD_CHANGELOG);
- changelog = fetchChangelogData(*m_cache,
- fetcher,
- candver,
- currver,
- &update_text,
- &updated,
- &issued);
+ changelog = "";
}
// Check if the update was updates since it was issued
Thanks for the heads-up! What version of PackageKit is this change scheduled to land in? > Thanks for the heads-up! What version of PackageKit is this change scheduled to land in?
the next release - v1.3.0 - to be released shortly (in a month)
@Sid, can you check if https://invent.kde.org/plasma/discover/-/merge_requests/865 fixes the issue? You will need the very latest Git master version of PackageKitQt to test the patch from that MR, as that version introduces the QPK_CHECK_VERSION macro that the MR relies on. > @Sid, can you check if https://invent.kde.org/plasma/discover/-/merge_requests/865 fixes the issue?
I've never used KDE nor built KDE apps from git. It's going to take a lot of time (which I'm afraid I don't have). I think it would be great, if one of the KDE Discover app devs can test this fix.
Steps to test the fix:
- Install a recent enough Ubuntu version in a VM (say, 23.10 minimal install)
- Install all updates of 23.10
- Run 'do-release-upgrade' command to trigger upgrade to 24.04. This should update /etc/apt/sources.list with 24.04 repo details.
- Try upgrading in KDE Discover.
- Upgrade should fail (without this patch) and pass (with patch).
A simpler way would be to get a system which has new-pkg installs and pkg removals as part of the update. I did the above distro upgrade, as I didn't have such a system state.
Git commit 83df60b726d5e6586509885d7927e6e0803e8322 by Matthias Klumpp. Committed on 18/06/2024 at 19:25. Pushed by apol into branch 'master'. packagekit: Add support for new action info enum values M +14 -0 libdiscover/backends/PackageKitBackend/PackageKitMessages.cpp M +10 -0 libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp https://invent.kde.org/plasma/discover/-/commit/83df60b726d5e6586509885d7927e6e0803e8322 Git commit 8204a2fd9d0f1b848155bd91670933cb6994c0ae by Aleix Pol Gonzalez. Committed on 18/06/2024 at 22:51. Pushed by apol into branch 'Plasma/6.1'. packagekit: Add support for new action info enum values (cherry picked from commit 83df60b726d5e6586509885d7927e6e0803e8322) Co-authored-by: Matthias Klumpp <matthias@tenstral.net> M +14 -0 libdiscover/backends/PackageKitBackend/PackageKitMessages.cpp M +10 -0 libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp https://invent.kde.org/plasma/discover/-/commit/8204a2fd9d0f1b848155bd91670933cb6994c0ae |