Bug 488178

Summary:	Baloo file daemon started using outdated QProcess API
Product:	[Frameworks and Libraries] frameworks-baloo	Reporter:	David Edmundson <kde>
Component:	Baloo File Daemon	Assignee:	baloo-bugs-null
Status:	CONFIRMED ---
Severity:	normal	CC:	nate, tagwerk19
Priority:	NOR
Version:	6.3.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:

Description David Edmundson 2024-06-07 19:50:48 UTC

Baloo is started manually in the following places with QProcess::startDetached
 - balooctl
 - qml monitor bindings
 - kcm (plasma-desktop)

This is problematic as it skips all features systemctl --user kde-baloo.service provides.
I strongly suspect this is how we end up with services not cleaned up properly.

This all needs porting to systemd startUnit/stopUnit with QProcess as a fallback for legacy support.

relevant code will be:
```
        auto msg = QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"),
                                                  QStringLiteral("/org/freedesktop/systemd1"),
                                                  QStringLiteral("org.freedesktop.systemd1.Manager"),
                                                  QStringLiteral("StartUnit"));
        msg << "kde-baloo.service" << QStringLiteral("fail");


    auto msg = QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"),
                                              QStringLiteral("/org/freedesktop/systemd1"),
                                              QStringLiteral("org.freedesktop.systemd1.Manager"),
                                              QStringLiteral("StopUnit"));
    msg << QStringLiteral("kde-baloo.service") << QStringLiteral("fail");
    QDBusConnection::sessionBus().call(msg);
```

Comment 1 tagwerk19 2024-06-07 23:02:53 UTC

This would be good...

Comment 2 tagwerk19 2024-06-11 07:19:01 UTC

Maybe also bundle up Bug 419708 in the change ...

... it seems strange to have to "balooctl enable" twice to get it to work.