| Summary: | Baloo file daemon started using outdated QProcess API | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-baloo | Reporter: | David Edmundson <kde> |
| Component: | Baloo File Daemon | Assignee: | baloo-bugs-null |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | 4wy78uwh, adam.m.fontenot+kde, nate, tagwerk19 |
| Priority: | NOR | ||
| Version: | 6.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=484463 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
This would be good... Maybe also bundle up Bug 419708 in the change ... ... it seems strange to have to "balooctl enable" twice to get it to work. |
Baloo is started manually in the following places with QProcess::startDetached - balooctl - qml monitor bindings - kcm (plasma-desktop) This is problematic as it skips all features systemctl --user kde-baloo.service provides. I strongly suspect this is how we end up with services not cleaned up properly. This all needs porting to systemd startUnit/stopUnit with QProcess as a fallback for legacy support. relevant code will be: ``` auto msg = QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"), QStringLiteral("/org/freedesktop/systemd1"), QStringLiteral("org.freedesktop.systemd1.Manager"), QStringLiteral("StartUnit")); msg << "kde-baloo.service" << QStringLiteral("fail"); auto msg = QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.systemd1"), QStringLiteral("/org/freedesktop/systemd1"), QStringLiteral("org.freedesktop.systemd1.Manager"), QStringLiteral("StopUnit")); msg << QStringLiteral("kde-baloo.service") << QStringLiteral("fail"); QDBusConnection::sessionBus().call(msg); ```