| Summary: | Loading overlay doesn't cover full page when entering Edit Page mode | ||
|---|---|---|---|
| Product: | [Applications] plasma-systemmonitor | Reporter: | tqd8 <tempqd888> |
| Component: | general | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ahiemstra, kde, nate, plasma-bugs |
| Priority: | NOR | Keywords: | regression |
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=494902 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/eee81c58dc0169753ef17a68c663600685c701f6 | Version Fixed In: | 6.1.1 |
| Sentry Crash Report: | |||
| Attachments: |
Screencast of loading overlay issue, not covering full page
Elements overlapping scrollbar while loading overlay is present |
||
Can reproduce. I think the culprit might be here? https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/page/EditablePage.qml?ref_type=heads#L206 I don't have the ability to test changes to this right now, but I'm listing this here just in case it helps out. Yes, that looks quite suspicious. Thanks! Actually it was something else. Patch incoming. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/299 Ah nice thanks! Git commit 3951c374c25fed5ef518e044273b47c6c5923e3d by Nate Graham. Committed on 13/06/2024 at 15:28. Pushed by ngraham into branch 'master'. EditablePage: position loading placeholder overlay correctly It was using negative margins to counteract the ones added to the page, but was then re-parented to something that wasn't the page. If those two things didn't have the exact same geometry, the overlay would be mis-positioned. Fix this by dropping the re-parenting, and instead manually set the Z to something very high to ensure it always covers the content. FIXED-IN: 6.1.1 M +1 -1 src/page/EditablePage.qml https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/3951c374c25fed5ef518e044273b47c6c5923e3d Git commit eee81c58dc0169753ef17a68c663600685c701f6 by Nate Graham. Committed on 14/06/2024 at 13:02. Pushed by ngraham into branch 'Plasma/6.1'. EditablePage: position loading placeholder overlay correctly It was using negative margins to counteract the ones added to the page, but was then re-parented to something that wasn't the page. If those two things didn't have the exact same geometry, the overlay would be mis-positioned. Fix this by dropping the re-parenting, and instead manually set the Z to something very high to ensure it always covers the content. FIXED-IN: 6.1.1 (cherry picked from commit 3951c374c25fed5ef518e044273b47c6c5923e3d) Co-authored-by: Nate Graham <nate@kde.org> M +1 -1 src/page/EditablePage.qml https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/eee81c58dc0169753ef17a68c663600685c701f6 Created attachment 171390 [details]
Elements overlapping scrollbar while loading overlay is present
Looks like another similar issue is happening now (on today's git master). Not sure if it was there before.
When the loading overlay pops up, the underlying content can overlap the scrollbar (visible if you hover to highlight it).
Note this only happens when the page doesn't have a scrollbar to begin with and only gets a scrollbar when the overlay appears. (That's maybe another bug: it seems the overlay is taller than the page, so when it appears, it gets a scrollbar no matter what.) So I'm guessing the margins/anchors of the elements underneath somehow don't take this temporary scrollbar width into account?
Not sure if I should reopen or file a new bug report.
I can't reproduce that with current git master. Can you describe how you're accomplishing it? 1. Ensure the System Monitor page is scaled large enough so that it has no scrollbar 2. Click "Edit Page" 3. A scrollbar appears -- move your mouse all around it. You should see the blue squares peeking into the scrollbar where your mouse hovers (like in my screenshot). Note: this doesn't happen if, in step 1, the page is small enough that it *does* have a scroll bar to begin with. Can you open a new bug report for it? Sure! Bug 494902 |
Created attachment 170154 [details] Screencast of loading overlay issue, not covering full page When clicking "Edit Page", the full-page overlay (containing the spinning gear icon) appears to cover only part of the page. The System Monitor sections on the page seem to peek out over the top of the overlay. Video attached. Happens at fractional and 100% scale, X11 and Wayland, at any window size. OS: openSUSE Krypton (today's git master)