Bug 487822

Summary: "Wipe all tags from Database only" crashes digiKam
Product: [Applications] digikam Reporter: CM <carlo.mj.m>
Component: Tags-ManagerAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: caulier.gilles
Priority: NOR    
Version First Reported In: 8.3.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/-/commit/3d721af026bd996f79771b32b290f65167150ac3 Version Fixed/Implemented In: 8.4.0
Sentry Crash Report:

Description CM 2024-05-31 04:53:52 UTC 
SUMMARY
"Wipe all tags from Database only" crashes digiKam

STEPS TO REPRODUCE
1. Go to Tag Manager
2. Click Sync Export
3. Click Wipe all tags from Database only

OBSERVED RESULT
The wipe seems to complete, but it crashes digiKam

EXPECTED RESULT
The wipe should complete, but keep digiKam running

SOFTWARE/OS VERSIONS
Windows: 11
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2024-05-31 06:31:49 UTC 
We need a debugger backtrace to investiguate.

Look in the Windows section of the contribute page :

https://www.digikam.org/contribute/

Gilles Caulier
Comment 2 Maik Qualmann 2024-05-31 10:46:47 UTC 
Git commit 93604e2aae2aaf0788f003cbc6b2fff4a91a9853 by Maik Qualmann.
Committed on 31/05/2024 at 10:46.
Pushed by mqualmann into branch 'master'.

do not read image IDs of the tags that are deleted,
this is not necessary and faster

M  +1    -4    core/libs/tags/manager/tagsmanager.cpp

https://invent.kde.org/graphics/digikam/-/commit/93604e2aae2aaf0788f003cbc6b2fff4a91a9853
Comment 3 Maik Qualmann 2024-06-01 14:22:24 UTC 
Git commit 3d721af026bd996f79771b32b290f65167150ac3 by Maik Qualmann.
Committed on 01/06/2024 at 14:20.
Pushed by mqualmann into branch 'master'.

change the album deletion order in the view models
FIXED-IN: 8.4.0

M  +1    -1    NEWS
M  +12   -13   core/libs/album/engine/album.cpp
M  +6    -1    core/libs/album/engine/album.h
M  +1    -1    core/libs/album/manager/albummanager.h
M  +8    -6    core/libs/album/manager/albummanager_dalbum.cpp
M  +4    -3    core/libs/album/manager/albummanager_palbum.cpp
M  +8    -6    core/libs/album/manager/albummanager_salbum.cpp
M  +5    -4    core/libs/album/manager/albummanager_talbum.cpp
M  +5    -6    core/libs/models/abstractalbummodel.cpp
M  +1    -1    core/libs/models/abstractalbummodel.h

https://invent.kde.org/graphics/digikam/-/commit/3d721af026bd996f79771b32b290f65167150ac3