Bug 487760

Summary:	If Panel settings dialog was opened while already in Edit Mode, closing it also undesirably exits from Edit Mode
Product:	[Plasma] plasmashell	Reporter:	Andres Betts <anditosan1000>
Component:	Edit Mode	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	cwo.kde, kdedev, nate, niccolo.venerandi, notmart, postix
Priority:	NOR	Keywords:	usability
Version:	master
Target Milestone:	1.0
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/1a7b1593e0e9d21cc6cb0901f1d0bf197373158e	Version Fixed In:	6.2.0
Sentry Crash Report:

Description Andres Betts 2024-05-29 19:16:30 UTC

SUMMARY

In the current edit mode interaction, when the user closes the panel edit dialog, edit mode closes. When the user clicks the widget sidebar to close it, this closes edit mode.

This leads to users who are not done in edit mode to have to constantly reopen edit mode to do more tasks. Given that the edit mode concentrates a few interactions into one main edit interaction, the user should not exit edit mode involuntarily. Instead, the user should click on the final call to action, such as "exit edit mode" and then close the interaction.

Comment 1 Andres Betts 2024-05-29 23:02:27 UTC

I forgot to mention that the escape key can also be the way to exit edit mode. It would be esc key until all dialogs are closed. When none are left, the user should exit edit mode.

Comment 2 Marco Martin 2024-05-30 12:15:15 UTC

this is probably petter discussed in vdg channel rather than tracked on bugzilla?

Comment 3 Andres Betts 2024-05-30 12:37:03 UTC

I submitted it here because it's a ux bug.

Comment 4 Nate Graham 2024-06-12 19:08:15 UTC

It's a valid UX issue IMO. If you showed the panel settings dialog from global edit mode, then closing it should just close it, not also exit global edit mode.

Comment 5 cwo 2024-06-18 20:12:42 UTC

Regarding the Escape key, this at present already only closes the Panel Configuration interface, but it does so irrespective of whether it was opened directly or whether Edit Mode was manually activated beforehand. (So the opposite of what closing the interface through the button does).

Comment 6 Bug Janitor Service 2024-07-07 16:35:41 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2376

Comment 7 Niccolò Venerandi 2024-08-29 14:53:15 UTC

Git commit 1a7b1593e0e9d21cc6cb0901f1d0bf197373158e by Niccolò Venerandi.
Committed on 29/08/2024 at 14:52.
Pushed by niccolove into branch 'master'.

Only exit edit mode upon panel config close if we did not enter via desktop context menu

M  +9    -3    containmentactions/contextmenu/menu.cpp
M  +18   -0    shell/desktopview.cpp
M  +4    -0    shell/desktopview.h
M  +9    -1    shell/panelview.cpp
M  +10   -0    shell/shellcorona.cpp
M  +2    -0    shell/shellcorona.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/1a7b1593e0e9d21cc6cb0901f1d0bf197373158e