| Summary: | No keyboard light control and always on by default | ||
|---|---|---|---|
| Product: | [Plasma] Powerdevil | Reporter: | Iyán Méndez Veiga <me> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | bugs.kde.org, jpetso, kde, natalie_clarius, nate, qydwhotmail |
| Priority: | NOR | Keywords: | regression |
| Version: | 6.1.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Iyán Méndez Veiga
2024-05-29 13:50:53 UTC
There was a typo in my report: I meant the Brightness and Color plasmoid. I did a git bisect from tags 6.0.4 to 6.0.90 and this is what I found: fe9e90f51728c8ba16aa5597f909018e213191a8 is the first bad commit commit fe9e90f51728c8ba16aa5597f909018e213191a8 (HEAD) Author: Bogdan Onofriichuk <bogdan.onofriuchuk@gmail.com> Date: Tue Dec 19 12:02:56 2023 +0200 Extract keyboard brightness into separate class. daemon/CMakeLists.txt | 9 +++++++++ daemon/actions/bundled/dimdisplay.cpp | 5 +++-- daemon/actions/bundled/dpms.cpp | 5 ++--- daemon/actions/bundled/handlebuttonevents.cpp | 8 ++++---- daemon/actions/bundled/keyboardbrightnesscontrol.cpp | 27 ++++++++++++-------------- daemon/actions/bundled/keyboardbrightnesscontrol.h | 2 +- daemon/backends/upower/CMakeLists.txt | 5 ----- daemon/backends/upower/powerdevilupowerbackend.cpp | 101 +------------------------------------------------------------------------------------------------ daemon/backends/upower/powerdevilupowerbackend.h | 13 ------------- daemon/controllers/keyboardbrightnesscontroller.cpp | 149 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ daemon/controllers/keyboardbrightnesscontroller.h | 51 +++++++++++++++++++++++++++++++++++++++++++++++++ daemon/powerdevilaction.cpp | 2 +- daemon/powerdevilaction.h | 2 +- daemon/powerdevilbackendinterface.cpp | 27 -------------------------- daemon/powerdevilbackendinterface.h | 20 -------------------- daemon/powerdevilcore.cpp | 12 ++++++++++++ daemon/powerdevilcore.h | 6 ++++++ 17 files changed, 252 insertions(+), 192 deletions(-) create mode 100644 daemon/controllers/keyboardbrightnesscontroller.cpp create mode 100644 daemon/controllers/keyboardbrightnesscontroller.h Can you ensure there are no stray old files in ./plugins/powerdevil in wherever you install your software >1. The slider is missing in the power and battery plasmoid
Note that this moved to a new brightness applet
When you did the bisect which one of the 3 things above are you referring to? Hi David, Regarding point one I already added a comment because I couldn't update the original description. Indeed, when it works, the slides is in the "Brightness and Color" applet. I first noticed the issues with the package provided by Arch Linux in the [kde-unstable] repo, which if I do `pacman -Ql powerdevil | grep plugins` lists the following: powerdevil /usr/lib/qt6/plugins/ powerdevil /usr/lib/qt6/plugins/plasma/ powerdevil /usr/lib/qt6/plugins/plasma/kcms/ powerdevil /usr/lib/qt6/plugins/plasma/kcms/systemsettings/ powerdevil /usr/lib/qt6/plugins/plasma/kcms/systemsettings/kcm_powerdevilprofilesconfig.so powerdevil /usr/lib/qt6/plugins/powerdevil/ powerdevil /usr/lib/qt6/plugins/powerdevil/action/ powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_brightnesscontrolaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_dimdisplayaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_dpmsaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_handlebuttoneventsaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_keyboardbrightnesscontrolaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_powerprofileaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_runscriptaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_suspendsessionaction.so For the git bisect I used the exact same PKGBUILD just changing the source to use the git repo and forcing the commit given by git bisect. Each build was done in a clean env using the [kde-unstable] repo (with kde-unstable-x86_64-build). And I was checking for the three issues. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4378 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4378 Does `qdbus6 --system org.freedesktop.UPower /org/freedesktop/UPower/KbdBacklight org.freedesktop.UPower.KbdBacklight.GetBrightness` return anything? (In reply to Fushan Wen from comment #9) > Does `qdbus6 --system org.freedesktop.UPower > /org/freedesktop/UPower/KbdBacklight > org.freedesktop.UPower.KbdBacklight.GetBrightness` return anything? It returns a 0. And a 1 and a 2 in the two other two brightness modes. On more thing I just discover. If I run `systemctl --user restart plasma-powerdevil.service`, everything works again. So the problem is that after that commit, and after a system reboot, it doesn´t work. The service has to be manually restarted. A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/377 Git commit 14f4cf0158d8565365dae1c5c55c2fac5801ef08 by Fushan Wen. Committed on 12/06/2024 at 03:58. Pushed by fusionfuture into branch 'master'. applets/brightness: test setting keyboard brightness This adds a test to make sure the keyboard brightness slider works as expected. M +6 -0 appiumtests/applets/CMakeLists.txt A +153 -0 appiumtests/applets/brightnesstest.py M +30 -0 appiumtests/utils/OrgFreedesktopUPower.py M +4 -2 applets/brightness/package/contents/ui/BrightnessItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/14f4cf0158d8565365dae1c5c55c2fac5801ef08 Hi, I'm also encountering this bug and can confirm it's rooted in the UPower service being stopped when PowerDevil tries to access it. So `systemctl --user restart plasma-powerdevil.service` works. To reproduce try: systemctl --user stop plasma-powerdevil.service sudo systemctl stop upower systemctl --user start plasma-powerdevil.service I'm running Plasma 6.1.3 (on NixOS unstable). Best As a workaround I let the service ping the dbus address in ExecStartPre. WorksForMe. cat .config/systemd/user/plasma-powerdevil.service.d/override.conf [Service] ExecStartPre=qdbus --system org.freedesktop.UPower / This is still an issue in 6.1.90. *** This bug has been marked as a duplicate of bug 486067 *** |