Bug 487737

Summary: Disabling Show Next feature only affects the scoring system until the user restarts the game
Product: [Applications] klines Reporter: gostak21
Component: generalAssignee: Dmitry Suzdalev <dimsuz>
Status: RESOLVED FIXED    
Severity: normal CC: aacid, kde-games-bugs-null
Priority: NOR    
Version First Reported In: 1.6.21123   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: https://invent.kde.org/games/klines/-/commit/b27867848342368ad781dc24a5f66c53425014d1 Version Fixed/Implemented In:
Sentry Crash Report:

Description gostak21 2024-05-29 12:28:16 UTC 
SUMMARY

The bug happens when the Show Next feature is disabled.
Immediately after disabling the Show Next feature, scores are awarded correctly (11 for 5 removed marbles).
After starting New Game (Game -> New), scores are awarded incorrectly as if Show Next was enabled (10 for 5 removed marbles).

STEPS TO REPRODUCE
1. Launch Kolor Lines. Disable Settings -> Show Next. (If it was already disabled, enable it and then disable again.)
2. Play the game and observe that completing a line of 5 marbles gives score 11.
3. Restart the game (Game -> New).
4. Play the game and observe that completing a line of 5 marbles gives score 10 now, even though Show Next is still disabled.

OBSERVED RESULT

Disabling "Settings -> Show Next" only affects the scoring system until the user restarts the game.

EXPECTED RESULT

Disabling "Settings -> Show Next" affects the scoring system for all subsequent games, until the user enables "Settings -> Show Next" again.
Comment 1 Bug Janitor Service 2024-06-07 12:10:13 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/games/klines/-/merge_requests/15
Comment 2 Albert Astals Cid 2024-06-10 20:16:47 UTC 
Git commit 90462cbe65b909c5f52218e9e866b2940e311514 by Albert Astals Cid.
Committed on 10/06/2024 at 20:14.
Pushed by aacid into branch 'master'.

Fix bonus for hidden preview not being conserved after new game

M  +1    -0    src/klines.cpp

https://invent.kde.org/games/klines/-/commit/90462cbe65b909c5f52218e9e866b2940e311514
Comment 3 Albert Astals Cid 2024-06-10 20:17:44 UTC 
Git commit b27867848342368ad781dc24a5f66c53425014d1 by Albert Astals Cid.
Committed on 10/06/2024 at 20:17.
Pushed by aacid into branch 'release/24.05'.

Fix bonus for hidden preview not being conserved after new game
(cherry picked from commit 90462cbe65b909c5f52218e9e866b2940e311514)

M  +1    -0    src/klines.cpp

https://invent.kde.org/games/klines/-/commit/b27867848342368ad781dc24a5f66c53425014d1