Bug 487562

Summary: Kicker button too wide with default icon
Product: [Plasma] plasmashell Reporter: Sebastian Friedl <sfr682k>
Component: Application Menu (Kicker)Assignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: garirry, joey.joey586, nate, p.wibberley, serfreeman1337
Priority: NOR Keywords: regression
Version: 6.0.5   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 6.1
Sentry Crash Report:
Attachments: Kicker's button with the default icon on a 36px horizontal panel

Description Sebastian Friedl 2024-05-26 01:21:14 UTC
Created attachment 169838 [details]
Kicker's button with the default icon on a 36px horizontal panel

SUMMARY
Kicker's button is too wide when using a horizontal panel and the default icon

STEPS TO REPRODUCE
1. Create a horizontal panel and add Kicker

OBSERVED RESULT
Kicker's button is too wide (see attached screenshot of a 36px panel, Kicker's button has a width of ca. 58px).

EXPECTED RESULT
Kicker's button has a reasonable size

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1
Graphics Platform: Wayland

ADDITIONAL INFORMATION
* This probably regressed with MR 2234, 6.0.4 was not affected
* Choosing a custom icon (even if its just "start-here-kde-plasma") fixes the bug, it only occurs when customButtonImage=... is not set in .config/plasma-org.kde.plasma.desktop-appletsrc
* To reproduce, it is NOT sufficient to reset the icon in Kicker's settings as this does not delete the customButtonImage entry
Comment 1 Niccolò Venerandi 2024-05-31 08:32:27 UTC
*** Bug 487749 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2024-06-07 08:05:38 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2295
Comment 3 Nate Graham 2024-06-07 16:22:08 UTC
Oops, thanks for fixing my mistake.
Comment 4 Nate Graham 2024-06-07 16:30:05 UTC
Git commit 7cf652d006bcb474d538fb5ccbff76a2a56f8c94 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 07/06/2024 at 16:30.
Pushed by ngraham into branch 'master'.

applets/kicker: Do not set a minimum size

In c06fe1b26bc88405eb490096e4cbd12148e68457, Nate  wanted to set a
maximum size for Kicker; however that was done by setting it as a
*minimum* size, which meant Kicker would always be too tall/wide.
FIXED-IN: 6.1

M  +4    -2    applets/kicker/package/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/7cf652d006bcb474d538fb5ccbff76a2a56f8c94
Comment 5 Nate Graham 2024-06-07 16:53:48 UTC
Git commit f113bf167a81d5034e864e4f923969dd5fe5c647 by Nate Graham.
Committed on 07/06/2024 at 16:33.
Pushed by ngraham into branch 'Plasma/6.1'.

applets/kicker: Do not set a minimum size

In c06fe1b26bc88405eb490096e4cbd12148e68457, Nate  wanted to set a
maximum size for Kicker; however that was done by setting it as a
*minimum* size, which meant Kicker would always be too tall/wide.
FIXED-IN: 6.1


(cherry picked from commit 7cf652d006bcb474d538fb5ccbff76a2a56f8c94)

deb12f20  Do not set a minimum size for Kicker

Co-authored-by: Niccolò Venerandi <niccolo@venerandi.com>

M  +4    -2    applets/kicker/package/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/f113bf167a81d5034e864e4f923969dd5fe5c647
Comment 6 Nate Graham 2024-06-10 20:58:00 UTC
*** Bug 488064 has been marked as a duplicate of this bug. ***
Comment 7 Peter 2024-06-19 16:01:36 UTC
(In reply to Nate Graham from comment #6)
> *** Bug 488064 has been marked as a duplicate of this bug. ***

6.1 solved.  Problem solved.  Thank you.