| Summary: | Buggy corners when using background blur | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Artem <stasyukartem2> |
| Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | anael, kwin-bugs-null, nate, notmart, uhhadd |
| Priority: | NOR | Keywords: | wayland |
| Version: | 6.1.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/1fbb7426987da5f57da23e094a120efd8ff9b3dd | Version Fixed In: | 6.2.0 |
| Sentry Crash Report: | |||
| Attachments: |
Comparison of the corners with and without blur
Konsole With Blur Konsole Wihtout Blur Plastik window decoration |
||
|
Description
Artem
2024-05-25 15:54:41 UTC
Created attachment 169820 [details]
Konsole With Blur
Created attachment 169821 [details]
Konsole Wihtout Blur
Does the issue only happen in Konsole, or any other apps too? Does the issue still happen in Konsole when using a window decoration theme that isn't Breeze? (In reply to Nate Graham from comment #3) > Does the issue only happen in Konsole, or any other apps too? > > Does the issue still happen in Konsole when using a window decoration theme > that isn't Breeze? Hey Nate, thanks for your answer, because only Konsole natively supports the blur protocol, yes. The context menu (right click) has no issues, because in 6.1 the issue with corners got fixed. I will check later on oxygen window decoration if it's different. (In reply to Nate Graham from comment #3) > Does the issue only happen in Konsole, or any other apps too? > > Does the issue still happen in Konsole when using a window decoration theme > that isn't Breeze? I have tried to use for example Plastik, and the corners there aren't buggy, the blur is not rounded. Created attachment 170510 [details]
Plastik window decoration
Theoretically, what can fix this issue, is make the corners rounded, like on the top. Then the blur will be aligned correctly with the border How about a window decoration theme that isn't Breeze, but also has rounded corners? (In reply to Nate Graham from comment #8) > How about a window decoration theme that isn't Breeze, but also has rounded > corners? All the window decorations I have tested, had sharp corners on the bottom of the blur (the border itself was rounded) So it is only with the breeze decoration But did any of them have rounded top corners like Breeze does? Can you make sure to test with some themes that have rounded top corners to see if the issue happens when them as well? (In reply to Nate Graham from comment #10) > But did any of them have rounded top corners like Breeze does? Can you make > sure to test with some themes that have rounded top corners to see if the > issue happens when them as well? Yes, they all did, I picked different window decorations: with all round corners, with only top rounded corners, with all sharp, and all were fine, but the Breeze window decoration. Ok, thanks. I think this is kinda the expected behavior as the blur regiorn is sent as an 1 bit bitmap, so its rounded corners are actually pixelated. we need to change slightly the protocol at least on wayland to be able to have regions with antialiased borders (In reply to Marco Martin from comment #13) > I think this is kinda the expected behavior as the blur regiorn is sent as > an 1 bit bitmap, so its rounded corners are actually pixelated. we need to > change slightly the protocol at least on wayland to be able to have regions > with antialiased borders Thanks for your answer! Unfortunately I am not a QML/C++ developer, so can't help with it, but I think that we can make a merge request for fixing this issue. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6199 Git commit 1fbb7426987da5f57da23e094a120efd8ff9b3dd by Xaver Hugl. Committed on 06/08/2024 at 12:23. Pushed by zamundaaa into branch 'master'. plugins/blur: limit app-requested blur to the app surface It does not make any sense that blur would be extended to the decoration when the decoration doesn't request it M +5 -5 src/plugins/blur/blur.cpp https://invent.kde.org/plasma/kwin/-/commit/1fbb7426987da5f57da23e094a120efd8ff9b3dd |