Bug 487468

Summary:	Patch for calendar - Philippines holidays 2024
Product:	[Frameworks and Libraries] frameworks-kholidays	Reporter:	pmargeti34
Component:	general	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	task	CC:	pmargeti34, winter
Priority:	NOR
Version First Reported In:	6.2.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Proposed holidays file for Philippines 2024

Description pmargeti34 2024-05-24 10:27:56 UTC

Created attachment 169764 [details]
Proposed holidays file for Philippines 2024

Frameworks currently lacks a holidays file for Philippines.
Attached file contains compiled date from Official Gazette of the Republic of the Philippines.
Holidays in Philippines are subject to Presidential proclamations, so it needs to be updated on a yearly basis upon new Presidential proclamations.
It also includes the updated school year dates.
I've attempted to verify the validity of the data with native citizens of the Philippines.
I've tried to adhere to the format specified in https://invent.kde.org/frameworks/kholidays/-/blob/master/holidays/file-format.txt
I'm posting this as a bug report to start a discussion on it before a merge request can be opened.
Please feel free to point out any shortcomings or misinformation contained in the attached file.

Comment 1 Allen Winter 2024-05-31 14:43:47 UTC

fixed with commit 3f2e1ffbfdd6715c5eeb2ef3902ad0e6d97b4a53 in kholidays