Bug 487285

Summary: Date/Time correction tool applies corrections twice, and in seemingly random order
Product: [Applications] digikam Reporter: Jens <jens-bugs.kde.org>
Component: Plugin-Generic-TimeAdjustAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 8.4.0   
Target Milestone: ---   
Platform: Appimage   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/digikam/-/commit/45ac0cb26f0e2e4194283898c547a950e5c46c41 Version Fixed/Implemented In: 8.4.0
Sentry Crash Report:

Description Jens 2024-05-20 15:44:19 UTC 
SUMMARY
When using the date/time correction tool, there are two small issues that confuse me.
1. When pressing Apply, the correction is not applied in the order the files are listed in but seemingly random. The list selection then jumps around randomly which is confusing.
2. When pressing OK after having pressed Apply, the correction is applied *again*, which causes an unnecessary delay.

In both cases I was correcting the timestamp of mp4 video files using the "[x] use Exiftool" option, based on the mp4 filename which was YYYYMMDD_HHMMSS_*.mp4. 

STEPS TO REPRODUCE
1. Get videos named like above
2. Use date/time correction like described above
3. Observe issues like mentioned above

EXPECTED RESULT
1. Apply changes in the order the files are listed, or list the files in the order the changes are applied (preferably, the former)
2. Do not re-apply when changes have already been applied, and OK is pressed.

SOFTWARE/OS VERSIONS: KDE Neon 24.04 with all updates applied, & Digikam 20240512 appimage 64bit.
Comment 1 Maik Qualmann 2024-05-20 18:15:17 UTC 
Git commit 45ac0cb26f0e2e4194283898c547a950e5c46c41 by Maik Qualmann.
Committed on 20/05/2024 at 18:14.
Pushed by mqualmann into branch 'master'.

fix apply Date Time Adjust twice
FIXED-IN: 8.4.0

M  +1    -1    NEWS
M  +11   -3    core/dplugins/generic/metadata/timeadjust/timeadjustdialog.cpp

https://invent.kde.org/graphics/digikam/-/commit/45ac0cb26f0e2e4194283898c547a950e5c46c41
Comment 2 Maik Qualmann 2024-05-20 18:20:09 UTC 
We only have a limited influence on the order of processing; the same behavior can also be observed in BQM. We start a QThreadPool that processes the jobs according to free processor time.

Maik